From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa0-f45.google.com (mail-oa0-f45.google.com [209.85.219.45]) by dpdk.org (Postfix) with ESMTP id 509D1B396 for ; Wed, 17 Sep 2014 10:28:07 +0200 (CEST) Received: by mail-oa0-f45.google.com with SMTP id i7so857266oag.4 for ; Wed, 17 Sep 2014 01:33:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=tgG/vaDUH9PAlWp3YrOc7UbyAa0lKFo8UH2y2RCdTDc=; b=UMtAkGuodMF6rfX843Q4DyTNTEIHarL58fBC4b8wRghC38UJshqhEpK3AhcjYW0BNV DZ+c9tUlid9egT/VC3J9DqQ1wLZ6pjLogGrRLURidRDrGXKAHKuTOlsDZUlrAbP1K5jd 0VMnDxTEaJ9tFilW1ed55tCzKfAjJjB0y599HmOO/cZ8B3D1m/8eNOk3zUyr9JN4GKQm wiKyVaFISov6uFkV65GV22CndFzy3WPd9EcgcVL+/flsUl5L/S/zVcVG1/UwBAf53Hj2 ivqISQ+2u2DazfQ75L317p6JKoI42tTkx3XFJPE2NaOx/9xmv9fOZniduwQtR7rZ3MQX YA8A== X-Gm-Message-State: ALoCoQlL1qk4wSIFq1qj/OJ6eSVBM9EdMAjw+tY54IKhP8Y942EkA5lUgIH8PkcVpxs+ghltC4R2 MIME-Version: 1.0 X-Received: by 10.60.156.198 with SMTP id wg6mr16840231oeb.69.1410942826689; Wed, 17 Sep 2014 01:33:46 -0700 (PDT) Received: by 10.202.13.21 with HTTP; Wed, 17 Sep 2014 01:33:46 -0700 (PDT) In-Reply-To: References: Date: Wed, 17 Sep 2014 10:33:46 +0200 Message-ID: From: David Marchand To: "Zhang, Helin" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] i40e: Steps and required configurations of how to achieve the best performance! X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2014 08:28:07 -0000 Hello, Some questions/comments : On Wed, Sep 17, 2014 at 6:18 AM, Zhang, Helin wrote: > -- *Extended Tag: Enabled > Note that 'Extended Tag' might not be seen in some BIOS, see 'compile > settings' for doing that at runtime. > I am not sure I understand this point. Either you have a bios that configures extended tag and you don't need anything in the dpdk or your bios does not support it and you must set it at runtime ? Then why not just set it at runtime and we avoid touching bios config ? 5. Compile Settings: > -- Change below configuration items in config files > CONFIG_RTE_PCI_CONFIG=y > CONFIG_RTE_PCI_EXTENDED_TAG="on" > Why have this build option for what looks to be a runtime decision ? Why don't we have RTE_PCI_CONFIG always set and extended tag to "on" ? (which means that we can get rid of these build options) Looking at igb_uio code, I am a bit concerned that this option affects all "igb_uio" pci devices in dpdk. Can you ensure me that any pci device going through igb_uio (em, igb, ixgbe etc... devices) will behave well with this option enabled ? It would be better to have a per-device (or per-pmd) option. Plus, build option should really be avoided for any feature in dpdk (and we have a lot of cleanup work about this ...). > CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=y > Why is it disabled as a default ? Thanks. -- David Marchand