From: David Marchand <david.marchand@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id
Date: Thu, 3 Sep 2015 16:04:59 +0200 [thread overview]
Message-ID: <CALwxeUtHL+bzd92XeUcgeO4w6=J7XRPLb1NO3+2=vWY5-MiwMA@mail.gmail.com> (raw)
In-Reply-To: <CAFb4SLCuS70jtY+bsNM9e0=YoeBC614BD8XNyNhVeJPofAJ4aQ@mail.gmail.com>
Hello Ravi, Tetsuya,
On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur <rkerur@gmail.com> wrote:
> Let us know how you want us to fix this? To fix rte_eal_vdev_init and
> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches
> mentioned in earlier discussion. In addition to those we have another
> approach with changes isolated only to rte_ether component. I am attaching
> diffs (preliminary) with this email. Please let us know your inputs since
> it involves EAL component.
>
- This patch looks like a good ethdev cleanup (even if it really lacks some
context / commit log).
I wonder just why you only take the first part of the name in
rte_eth_dev_get_port_by_name().
Would not this match, let's say, both toto and toto0 vdevs ?
Is this intended ?
- In the end, with this patch, do we still need to update eal ?
Looking at the code, I am not sure anymore.
--
David Marchand
next prev parent reply other threads:[~2015-09-03 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 19:42 [dpdk-dev] [PATCH v2] Send updated port_id in vdev_init functions Ravi Kerur
2015-08-19 19:42 ` [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id Ravi Kerur
2015-08-20 2:07 ` Tetsuya Mukawa
2015-08-20 19:16 ` Ravi Kerur
2015-08-21 3:33 ` Tetsuya Mukawa
2015-08-25 17:59 ` Ravi Kerur
2015-09-03 14:04 ` David Marchand [this message]
2015-09-15 11:28 ` Ravi Kerur
2015-09-23 21:22 ` Ravi Kerur
2015-09-26 11:35 ` Tetsuya Mukawa
2015-09-29 3:32 ` Tetsuya Mukawa
2015-09-30 19:14 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUtHL+bzd92XeUcgeO4w6=J7XRPLb1NO3+2=vWY5-MiwMA@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).