From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f174.google.com (mail-ob0-f174.google.com
 [209.85.214.174]) by dpdk.org (Postfix) with ESMTP id CA1B33784
 for <dev@dpdk.org>; Thu,  3 Sep 2015 16:05:01 +0200 (CEST)
Received: by obbbh8 with SMTP id bh8so33089016obb.0
 for <dev@dpdk.org>; Thu, 03 Sep 2015 07:05:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=65UBn96VOtAXDZHV63EDiDIMYsHlflwtwpLDnoiKnxQ=;
 b=HYl030SDXweMf0YzmqG5lCslHFvTFKQAc3Yu+ftbqWV0KSPAEw95jMVzJf9/GDSqo0
 vpxy9+OjCDacrsROkdjHnE1mzWTYkTdt65B8gWSIqvjCZm2g94dIGUjyDgCGpgB1H5qP
 XGLjmy3di3vSZpiIheXxhPPJJCvIgHbarG26G66UFfaEoGniUHZBprj5LFo8/DuHiwmC
 rYxXrk9E1Lfhbs/M4hv54vhIScsdrgJdP3+lJxd5Vm8Q6Cp8xs87PNvhANabvFpTDuwE
 3cxRxrpxGiSnrW6NUKlNcXFQuIVsHmno3OekXCWm7Ti6/ukbYkm604aX2ACJGBVjvqqS
 M4vw==
X-Gm-Message-State: ALoCoQmmAx6Mxk/9m5l2yJF1VU5UFMnJJSpq17eZdbEpmm/FIP9ADWXvTDMkAm25kueQDuR5jUpH
MIME-Version: 1.0
X-Received: by 10.182.204.35 with SMTP id kv3mr27497213obc.58.1441289100106;
 Thu, 03 Sep 2015 07:05:00 -0700 (PDT)
Received: by 10.76.84.233 with HTTP; Thu, 3 Sep 2015 07:04:59 -0700 (PDT)
In-Reply-To: <CAFb4SLCuS70jtY+bsNM9e0=YoeBC614BD8XNyNhVeJPofAJ4aQ@mail.gmail.com>
References: <1440013341-29659-1-git-send-email-rkerur@gmail.com>
 <1440013376-29715-1-git-send-email-rkerur@gmail.com>
 <55D53655.1040808@igel.co.jp>
 <CAFb4SLBpa8LF2K6-tjK+bk20tKsoJLd2nwDqdmySJg=A9402Eg@mail.gmail.com>
 <55D69C00.2020609@igel.co.jp>
 <CAFb4SLCuS70jtY+bsNM9e0=YoeBC614BD8XNyNhVeJPofAJ4aQ@mail.gmail.com>
Date: Thu, 3 Sep 2015 16:04:59 +0200
Message-ID: <CALwxeUtHL+bzd92XeUcgeO4w6=J7XRPLb1NO3+2=vWY5-MiwMA@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Sep 2015 14:05:02 -0000

Hello Ravi, Tetsuya,

On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur <rkerur@gmail.com> wrote:

> Let us know how you want us to fix this? To fix rte_eal_vdev_init and
> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches
> mentioned in earlier discussion. In addition to those we have another
> approach with changes isolated only to rte_ether component. I am attaching
> diffs (preliminary) with this email. Please let us know your inputs since
> it involves EAL component.
>

- This patch looks like a good ethdev cleanup (even if it really lacks some
context / commit log).

I wonder just why you only take the first part of the name in
rte_eth_dev_get_port_by_name().
Would not this match, let's say, both toto and toto0 vdevs ?
Is this intended ?


- In the end, with this patch, do we still need to update eal ?
Looking at the code, I am not sure anymore.


-- 
David Marchand