From: David Marchand <david.marchand@6wind.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Xie, Huawei" <huawei.xie@intel.com>,
yuanhan.liu@intel.com
Subject: Re: [dpdk-dev] [PATCH] virtio: fix modify drv_flags for specific device
Date: Tue, 26 Apr 2016 13:53:49 +0200 [thread overview]
Message-ID: <CALwxeUtJ-MM8Wct+JXu4qizxZK7r5t2-VU8hh5YVz4FbDG4qDg@mail.gmail.com> (raw)
In-Reply-To: <1461637474-110602-1-git-send-email-jianfeng.tan@intel.com>
On Tue, Apr 26, 2016 at 4:24 AM, Jianfeng Tan <jianfeng.tan@intel.com> wrote:
> Issue: virtio's drv_flags are decided by devices types (modern vs legacy),
> and which kernel driver is used, and the negotiated features (especially
> VIRTIO_NET_STATUS) with backend, which makes it possible to multiple
> virtio devices have different versions of drv_flags, but this variable
> is currently shared by each virtio device.
>
> How to fix: dev_flags is a device-specific variable to store this info.
>
> Fixes: da978dfdc43 ("virtio: use port IO to get PCI resource")
>
> Reported-by: David Marchand <david.marchand@6wind.com>
> Suggested-by: David Marchand <david.marchand@6wind.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
- ethdev dev_flags is supposed to be filled with
RTE_ETH_DEV_DETACHABLE, RTE_ETH_DEV_INTR_LSC etc... not pci macros.
- I would have kept the init code as it is until the
rte_eth_copy_pci_info() step, then sanitise the dev_flags, but this
might be a matter of taste.
--
David Marchand
next prev parent reply other threads:[~2016-04-26 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 2:24 Jianfeng Tan
2016-04-26 11:53 ` David Marchand [this message]
2016-04-27 5:10 ` Tan, Jianfeng
2016-04-27 5:20 ` David Marchand
2016-04-28 18:08 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2016-05-02 17:55 ` Yuanhan Liu
2016-05-03 8:05 ` David Marchand
2016-05-04 23:18 ` Yuanhan Liu
2016-05-09 9:14 ` Tan, Jianfeng
2016-05-09 18:01 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUtJ-MM8Wct+JXu4qizxZK7r5t2-VU8hh5YVz4FbDG4qDg@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).