From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f48.google.com (mail-oi0-f48.google.com [209.85.218.48]) by dpdk.org (Postfix) with ESMTP id 2EACB4CE7 for ; Fri, 25 Mar 2016 09:48:44 +0100 (CET) Received: by mail-oi0-f48.google.com with SMTP id i21so42865834oig.1 for ; Fri, 25 Mar 2016 01:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DltuGnyABjp9uTe/4UDw1qUqCs7M/R6euLThRbhVf0U=; b=Uo0XoBMr6djSX0rBeRzpT6sGMXLoaljp4mv4EhsIxwFuvRw/W2BsSwtRP78wSZmhe4 /LfFwVXE6Tc5jDAZ5BznUbzB38Mqlu8JzX6H3u/yiKR3JiLIkjjXgyw5qaPBlA/hnm4O 21BSxjcTkSMWN/dIBRugTEJ4WLoEMZIuShRkIrWgdc5efVIC1r0U8Bt67qgs3Vm9ub1i Smf9VZxNXfoS+nv5/lDO7Pa4tI5HnclS3RACqYRn8DpITvmyCkkXNOeBfBZQgodBQjfC f+BKpTTthH7sOI7EXrwSmjC3qWhJqKrahjjDka2G9WfF8LOSohrrPyVFJBQFW0i1eV2P yQVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DltuGnyABjp9uTe/4UDw1qUqCs7M/R6euLThRbhVf0U=; b=CeoISM2YEqUbSL8KZCBz3nAGbI40EuSBcqxW+NZtWOCM1nVmeyAl9VCcf41qpKLNwt t4UNm5dz7vqo3Le8AfSz3uOnFk2dVJJYL/IwShBMkBtRPPAUyhF/D1UZ2YQRgUb5Lha8 HkKnkkPyZSjHL/Uddf1jdYQBcjB0xWNZupxS/hWGn/RU6f8x/I7f3P+ZI/Qhn4gj+Ohg 9gpfRYq5f/Yw04l+/DOfK9sCF0GIGENvV8t96bUt87ih9WZaYwARNwvLaWe2PVaH5hsq vNey5Z0M9i/gh5ReJoRQPhIbbwnhxVueEtIbdO7i5s6uP22J//BCnuNixRyfP8U/JH1L irEA== X-Gm-Message-State: AD7BkJJwAcCFkVntamJx9qCX4lqAIEHdunR9ygQQhdV0Ws9/W6dOTDxRjTzh3WqHoykeE0M2M3xDEvR8CNT1EIOu X-Received: by 10.157.6.230 with SMTP id 93mr5895714otx.176.1458895723582; Fri, 25 Mar 2016 01:48:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Fri, 25 Mar 2016 01:48:24 -0700 (PDT) In-Reply-To: <1458893513-22406-2-git-send-email-chaozhu@linux.vnet.ibm.com> References: <1458893513-22406-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1458893513-22406-2-git-send-email-chaozhu@linux.vnet.ibm.com> From: David Marchand Date: Fri, 25 Mar 2016 09:48:24 +0100 Message-ID: To: Chao Zhu Cc: "dev@dpdk.org" , "Richardson, Bruce" , Panu Matilainen Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 08:48:44 -0000 On Fri, Mar 25, 2016 at 9:11 AM, Chao Zhu wrote: > This patch fixes the max logic number and memory channel number settings > on IBM POWER8 platform. > 1. The max number of logic cores of a POWER8 processor is 96. Normally, > there are two sockets on a server. So the max number of logic cores > are 192. So this parch set CONFIG_RTE_MAX_LCORE to 256. This is a power8 configuration item, this should go to power8 config file, not common_base. > 2. Currently, the max number of memory channels are hardcoded to 4. However, > on a POWER8 machine, the max number of memory channels are 8. To fix this, > CONFIG_RTE_MAX_NCHANNELS is added to do the configuration. I don't see any reason why we would need a max value for force_nchannel. We should just get rid of this check, this is an obscure parameter for most people, so people playing with it know what they are doing (hopefully ?). On the other hand, if power8 has some specifics about it, maybe we should introduce some default value in a arch eal header for other dpdk components to use (like in mempool). Thoughts ? -- David Marchand