From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com
 [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id ADFDB3195
 for <dev@dpdk.org>; Tue, 12 Jan 2016 09:45:29 +0100 (CET)
Received: by mail-oi0-f50.google.com with SMTP id p187so50664538oia.2
 for <dev@dpdk.org>; Tue, 12 Jan 2016 00:45:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=XNGxvIZB0U0fMoQSS3yOxM/rYReR7uA874ox675oUco=;
 b=AIy8v9nJl6NkQeDuWVupdZhXnSQEHStESqk6hLyhDB1LxCZlItnGqo6+g84uzPdcPN
 5ujnnZqQlwuGW9YxUvZ3dAoWPj7QdZOiUlURjMt+X83LfUI7C/531/8IPGHvGnSyYghL
 Cu4UFBOtoNDpOp2skDgJnaRzr0N7vxVzdLGN/YustY3a1AgKfZ2nqoeThaMbfP37odEp
 PeWTRHcdNzI+fM5DMinu0a23zR89VdDIohSelQio6BhonmvyLhSaB4EWdW/QXIDkqGcm
 /5hU9nQtxFWsb4c7PURJHFlNFUp//FTz4MhijeHOM9vOxZ5EHC03c5C8swI43h4McA26
 i7vw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=XNGxvIZB0U0fMoQSS3yOxM/rYReR7uA874ox675oUco=;
 b=avx5KpQAJCjNyH4oGQ6fSL2yOqke/Ysm5mZh3lT+/zQ7o+1sNpuLso2Owe6pBf/txh
 H4Aa34MDe5sxduCggel1vMjXX+avxvZdXFgye1rzGlA2EN8o4o0e43vfv/HbOS/z0/4m
 tVqdghDD3+GqKNUo/6qDGt+o6YUwinkVdTH6CqoOUOL6Zp1V84tUX2EyPeutRBPWja3W
 qfaTvVgMnZx+q4/1Ht6wmkuWD26CTt0cqGSlCeblTYagG4bkwfy/d7AQRt9nOTPQ1Hmn
 iLI7R3HqAfaT7YG0EqSdxhbb8+INVHMERRrvBKW8uCSUeaDgDJ7XKsXpTOH2h2pjB0QD
 XcFA==
X-Gm-Message-State: ALoCoQnPjeRVkzAMO2/O/Gzk4Bqqa4ca6uqiec/yz84UwXE+kyDQcAAURYks1nB1d2SHQAk+aMzUN+3WpTaF5HbJDKxVlFAmNn9KhLnUNRbiVoNlCF6GMPM=
MIME-Version: 1.0
X-Received: by 10.202.241.11 with SMTP id p11mr90921101oih.51.1452588329020;
 Tue, 12 Jan 2016 00:45:29 -0800 (PST)
Received: by 10.76.180.72 with HTTP; Tue, 12 Jan 2016 00:45:28 -0800 (PST)
In-Reply-To: <20160110120208.702d22c5@xeon-e3>
References: <CALwxeUt49PB2TKy_V-9GoQYdDHP3GeBb5LK6jBxdLEYVnRY-vw@mail.gmail.com>
 <1452430254-30390-1-git-send-email-david.marchand@6wind.com>
 <1452430254-30390-4-git-send-email-david.marchand@6wind.com>
 <20160110120208.702d22c5@xeon-e3>
Date: Tue, 12 Jan 2016 09:45:28 +0100
Message-ID: <CALwxeUtYrFsDUKR3-8_93WfuAyQ=qCW_aGid9ooU09bcS2Pw3Q@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>, thomas.monjalon@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 03/11] i40e: move pci device ids to driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 08:45:30 -0000

On Sun, Jan 10, 2016 at 9:02 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> On Sun, 10 Jan 2016 13:50:46 +0100
> David Marchand <david.marchand@6wind.com> wrote:
>
> > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_SFP_XL710) },
> > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_QEMU) },
> > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_A) },
> > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_B) }
>
> You should indent the initializers.
>

Ok will do, but I don't like having to break lines because of the
80-columns limit (which happens in some drivers).

-- 
David Marchand