From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 32612C34E for ; Fri, 5 Feb 2016 18:57:15 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id w5so45685935oie.1 for ; Fri, 05 Feb 2016 09:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=/k8oLub2T1Fa0rd6almXVuxjYxd6HKHZYZlrgQfcBQo=; b=MQ8k/nEiwA8mt3N1U5R65WiWWZVpWe5HX04G0+6YHIwZjAeVcCBUIta/+A+ZUxOFTz NukwuwusqfKpsIg2LUIMJKm0jWY926AZj2fI+QqHMOKr8P9nxN6clLFqPQUr2FqxJ58g jQCw6Qn/W/Qc/v7i3MoKHB4vVfhYppwMEJHA2XcU9kf7KOPChW/C12PzLaHdnisYb1OC 0CtWO2hjCa/PLRovozSxFmTqalCGupd80s4KdWlyc6CJslhJc8NLT+GbbnnHlmCg/0Sy nDQJ+AVcJGK40HM3ms7XPP6rgtke78TRVbUCA7y3sDcEEjeJcxIn6AZPO+lKcO10nDlL Dl+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=/k8oLub2T1Fa0rd6almXVuxjYxd6HKHZYZlrgQfcBQo=; b=cIU4lFO3B5GLrBpiAqEICiBsL+Zd1CdM7bCAvEz8OTwIxnF7lpGSDVkuNhSihW6mND qy+paIfiS3meWSGqL4aRK+QyGunxUL6NxkQSne+I+kx4349CmvSyZYc+KHXnpe0FRSvb LvuDjLEy3d4raJS4BQqdcS0wiQH/jYJgEe+NGavNzcI3aJCm2cGXazHMI4EEYCsdlmq8 0YIEP4nn11NjwP0kxDTPas2ANTMaNt0IJ4awPd8RdBtbDjJVvgx7BZveVVPJ4Zhi2a9I HGuF7CCzXENu8D7lsGyVvKflsYVtV/OLuClh3KDmE5XmbxEqCbHvhffut3AAVAr2jQdM dLHA== X-Gm-Message-State: AG10YOQCsEMxsU7rPcUqLFFCEGx4SZ5JpbHNkCE5w6pq+lh7WwmvFyoDbzVNaEkpYSjLzAwYh2uOC+LJdJmsBA9m X-Received: by 10.202.235.7 with SMTP id j7mr9553251oih.4.1454695034613; Fri, 05 Feb 2016 09:57:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Fri, 5 Feb 2016 09:56:54 -0800 (PST) In-Reply-To: <20160203115022.GB16802@yliu-dev.sh.intel.com> References: <1454091717-32251-1-git-send-email-sshukla@mvista.com> <20160201134854.GE4257@yliu-dev.sh.intel.com> <20160202054345.GI4257@yliu-dev.sh.intel.com> <20160202084933.GJ4257@yliu-dev.sh.intel.com> <20160203115022.GB16802@yliu-dev.sh.intel.com> From: David Marchand Date: Fri, 5 Feb 2016 18:56:54 +0100 Message-ID: To: Yuanhan Liu , Santosh Shukla Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 1/8] eal: pci: add api to rd/wr pci bar region X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 17:57:15 -0000 On Wed, Feb 3, 2016 at 12:50 PM, Yuanhan Liu wrote: > On Wed, Feb 03, 2016 at 03:20:09PM +0530, Santosh Shukla wrote: >> Also can someone please review rest of series. This patchset going >> through multiple revision, Each revision get one / two comment, It >> would help if I get review comment for each patch. > > The others looks good to me; if you have the EAL pci API resolved > properly, I guess I could give my ACK. As discussed offlist, I just sent a patchset [1] that proposes a new api. This is not perfect, but I think this should be fine for x86 / arm. Santosh should be able to rebase his code on top of it. [1] http://dpdk.org/ml/archives/dev/2016-February/032778.html Regards, -- David Marchand