From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com
 [209.85.218.47]) by dpdk.org (Postfix) with ESMTP id 24E94C48C
 for <dev@dpdk.org>; Mon, 29 Jun 2015 14:10:19 +0200 (CEST)
Received: by oigb199 with SMTP id b199so116312778oig.3
 for <dev@dpdk.org>; Mon, 29 Jun 2015 05:10:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=eSzhq2Kju9hgryast0c8rJ27n0AR3lS2gJoGZchB2Vc=;
 b=nCpi6PBFYJuBpj3hPXTfnXOTmwh0H56OnucWFi80afVx1YjkgeX28YyQ060WL3TLp0
 qPKUXYucLk946v7t05NScklVUwINSNAm0Aw4JAkVgm+iDCz9xsXg34l45C1HHS5kp52H
 MVsmbqWfE16e7QLlq/IvJDdl+I7QWngc3YBsxl8ge4prjp37BXBVoYJtajx6w148TMdg
 WDgyn7QiW2YDVkbKnLAwSUwrpePH/6+QHkBgdmyt9jlAd/xjTahQrqKfWcUzZP/CxPDa
 QvtJzdBDjTzMXWh7wewhmN7K0Xx+tHmt7dxFy5Fw1GEZREXIrInpU8djyTXTx9VMPKVx
 FFPQ==
X-Gm-Message-State: ALoCoQnfoofTkNLpzWK8Zc+hWj41jyDHKquuQmVbeHKZxuqdO8FT2OZo0cEJZPLd+2T2BNI+NhFH
MIME-Version: 1.0
X-Received: by 10.182.75.170 with SMTP id d10mr11003329obw.76.1435579818382;
 Mon, 29 Jun 2015 05:10:18 -0700 (PDT)
Received: by 10.76.25.69 with HTTP; Mon, 29 Jun 2015 05:10:18 -0700 (PDT)
In-Reply-To: <1435570492-19291-1-git-send-email-adrien.mazarguil@6wind.com>
References: <6446943.entjzpE8eR@xps13>
 <1435570492-19291-1-git-send-email-adrien.mazarguil@6wind.com>
Date: Mon, 29 Jun 2015 14:10:18 +0200
Message-ID: <CALwxeUtcd2AcGJBdeh8rMUncvRUE8HiuLE1NeVvQEfQjf+Lywg@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix cpu_feature_table[] compilation
	with -pedantic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2015 12:10:19 -0000

On Mon, Jun 29, 2015 at 11:34 AM, Adrien Mazarguil <
adrien.mazarguil@6wind.com> wrote:

> Since the commit below includes rte_cpuflags.h in rte_spinlock.h,
> compilation of the mlx4 driver fails when CONFIG_RTE_LIBRTE_MLX4_DEBUG=y.
>
> This mode adds -pedantic to the compiler's command line for mlx4, which
> complains about the static definition of an empty cpu_feature_table[] in
> common rte_cpuflags.h, then about its redefinition as a larger array in
> arch-specific rte_cpuflags.h.
>
> While DPDK does not officially support -pedantic internally, external
> applications may enable it and include rte_spinlock.h from the public API.
>
> Instead of removing -pedantic from mlx4, this commit fixes rte_cpuflags.h.
>
> Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86")
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>

Acked-by: David Marchand <david.marchand@6wind.com>

-- 
David Marchand