DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log
@ 2015-02-14 15:32 Stephen Hemminger
  2015-02-14 15:32 ` [dpdk-dev] [PATCH 2/2] enic: change probe log message level Stephen Hemminger
  2015-02-14 16:28 ` [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log Neil Horman
  0 siblings, 2 replies; 5+ messages in thread
From: Stephen Hemminger @ 2015-02-14 15:32 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

Device driver should log via DPDK log, not to printf which is
sends to /dev/null in a daemon application.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_pmd_enic/enic_compat.h | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/librte_pmd_enic/enic_compat.h b/lib/librte_pmd_enic/enic_compat.h
index b1af838..c3ab76e 100644
--- a/lib/librte_pmd_enic/enic_compat.h
+++ b/lib/librte_pmd_enic/enic_compat.h
@@ -75,10 +75,13 @@
 #define kzalloc(size, flags) calloc(1, size)
 #define kfree(x) free(x)
 
-#define dev_err(x, args...) printf("rte_enic_pmd : Error - " args)
-#define dev_info(x, args...) printf("rte_enic_pmd: Info - " args)
-#define dev_warning(x, args...) printf("rte_enic_pmd: Warning - " args)
-#define dev_trace(x, args...) printf("rte_enic_pmd: Trace - " args)
+#define dev_printk(level, fmt, args...)	\
+	RTE_LOG(level, PMD, "rte_enic_pmd:" fmt, ## args)
+
+#define dev_err(x, args...) dev_printk(ERR, args)
+#define dev_info(x, args...) dev_printk(INFO,  args)
+#define dev_warning(x, args...) dev_printk(WARNING, args)
+#define dev_debug(x, args...) dev_printk(DEBUG, args)
 
 #define __le16 u16
 #define __le32 u32
-- 
2.1.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-02-24  2:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-14 15:32 [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log Stephen Hemminger
2015-02-14 15:32 ` [dpdk-dev] [PATCH 2/2] enic: change probe log message level Stephen Hemminger
2015-02-14 16:28 ` [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log Neil Horman
2015-02-23 16:43   ` David Marchand
2015-02-24  2:37     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).