From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by dpdk.org (Postfix) with ESMTP id 246C7B3C5 for ; Tue, 26 Aug 2014 16:51:43 +0200 (CEST) Received: by mail-oi0-f47.google.com with SMTP id x69so10797369oia.34 for ; Tue, 26 Aug 2014 07:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=UJ9cTC/32lgi/GQK3VnoknreDT3dxVSleXuHpBqYVoQ=; b=eQs1B9M00eGmJQI8r3SszLaVCfvEd1UIG310QA3RwVqZRaZ9nHpubLrO2X+db6Xl4d x2VIXuoqtest5GuY2d3rUzScg9Z2HW9TrSsAVhB5OWT/U8GxCB55NyuZZ/I6AOu6H7kQ Sni5KZpc0F4P3YCrwklTOWf3+58GTES9KEGu+n/u96O+QiWwfpp6wgXyGR5dO0/lRYab b9fSUyqSrylqt+hlCcjv2g7rDpPpB9FhzrIKyDJjtZLZiStb5x1KePVlzP1GC8GT3jGS lkEwqBrEUuFm6oj5H6aBO3j7oXZJopb7s7UJxErimsIidmmAuzDn4VYrGyhloyxngj+e hWYQ== X-Gm-Message-State: ALoCoQmtfjSyrQ9ko+JmG0hULdSBRgoFVgRjDxzqVkuSTgNiM0zd4nnOh23Y0YwLUCzQiZV3PJIn MIME-Version: 1.0 X-Received: by 10.60.67.34 with SMTP id k2mr28037183oet.52.1409064942258; Tue, 26 Aug 2014 07:55:42 -0700 (PDT) Received: by 10.202.214.88 with HTTP; Tue, 26 Aug 2014 07:55:42 -0700 (PDT) In-Reply-To: References: <1409062162-19575-1-git-send-email-david.marchand@6wind.com> <1409062162-19575-2-git-send-email-david.marchand@6wind.com> Date: Tue, 26 Aug 2014 16:55:42 +0200 Message-ID: From: David Marchand To: Jay Rolette Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 01/11] ixgbe: clean log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 14:51:43 -0000 Hello Jay, On Tue, Aug 26, 2014 at 4:23 PM, Jay Rolette wrote: > Why are you adding newlines to log message strings? Shouldn't that be up > to whatever the messages end up getting routed to? > Actually, I wanted to have consistent log formats in the PMDs so that the log messages displayed at runtime are aligned (and not bouncing with \n before or after the log message). There was two solutions from my point of view : - either always add a \n in the log macro and remove all trailing \n - do the opposite I preferred the latter as it let users of the macro set the message format as they want. Before this change : Configuring Port 0 (socket 1) PMD: ixgbe_dev_tx_queue_setup(): sw_ring=0x7f3e59cd8080 hw_ring=0x7f3e59d02080 dma_addr=0x727702080 PMD: ixgbe_dev_tx_queue_setup(): Using simple tx code path PMD: ixgbe_dev_tx_queue_setup(): Vector tx enabled. PMD: ixgbe_dev_rx_queue_setup(): sw_ring=0x7f3e59cd57c0 hw_ring=0x7f3e59d12080 dma_addr=0x727712080 PMD: ixgbe_dev_rx_queue_setup(): Rx Burst Bulk Alloc Preconditions are satisfied. Rx Burst Bulk Alloc function will be used on port=0, queue=0. PMD: ixgbe_dev_rx_queue_setup(): Vector rx enabled, please make sure RX burst size no less than 32. After this change : Configuring Port 0 (socket 1) PMD: ixgbe_dev_tx_queue_setup(): sw_ring=0x7fd47ecd8080 hw_ring=0x7fd47ed02080 dma_addr=0x727702080 PMD: ixgbe_dev_tx_queue_setup(): Using simple tx code path PMD: ixgbe_dev_tx_queue_setup(): Vector tx enabled. PMD: ixgbe_dev_rx_queue_setup(): sw_ring=0x7fd47ecd57c0 hw_ring=0x7fd47ed12080 dma_addr=0x727712080 PMD: ixgbe_dev_rx_queue_setup(): Rx Burst Bulk Alloc Preconditions are satisfied. Rx Burst Bulk Alloc function will be used on port=0, queue=0. PMD: ixgbe_dev_rx_queue_setup(): Vector rx enabled, please make sure RX burst size no less than 32. Port 0: 90:E2:BA:29:DF:58 -- David Marchand