From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id D18772B96 for ; Wed, 7 Dec 2016 13:22:04 +0100 (CET) Received: by mail-wj0-f180.google.com with SMTP id tk12so64061113wjb.3 for ; Wed, 07 Dec 2016 04:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GBerOu6waxE6BYIm8Ms6vuul5kAiwbOor/DRlNtoDZI=; b=tPGTD+HFxTyafv+O+adFJufoEQoEEV6G8Wdb+oxbNDSs+sfa7bq9m7Un0WDDk0dTD2 30OQVrrtx/c+9GMpxhtDgQVO/ruQ9saDbV0Lf37t8qGJot87Mcft675zte3b+9DRz8Tr 08RyaHK27PXf1DcQwYEnU1knBV9X4usF4fBVoT+NROE4NaJ3JPvXvam5r5goA8HxLbLc Bn0UBScgUzBxQpkuBOTg9w2roo+BvV1ne3ZUhLubx6/jgvNoeR3nFI0SwG4MULWcq3ia ez9HZre4vvsLJYGNclgHdl2ln+55TW1YIEZlO1E0OyWxElnB9TJmdg48YgaiGOxAXtkQ NR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GBerOu6waxE6BYIm8Ms6vuul5kAiwbOor/DRlNtoDZI=; b=cCq3yvKPRtCzImm7Qcv9wR7iG9yWuXm7S5uUKtxmomoUFdR8GMWNJ5x+5/1RD56wQw j/glbjVWa2fr0l7cwRapLxQLAv9ySxeVGPcQCkPqbus0EQCAvtWoGFg9LEEiD+5F01WI rIiWj3D6TnkT2jsZibVOJvxG90HwFXcUEtHiEcMaPZ/VCAuGXgbPX+WA3bSDel/W5/3T HzGu0ObturZVMma1coTm7N4H4Nic5CSxvfsgQKRcFITUZX58eJMPwDf+Jb7P7/DaJ2w7 nLMQJ291UvxvNu8wcSU/ZJbIwWm9W6yQbf9Cnnwn//k7XqGoJR1vdvTr8Mt/Zk+AX3qV uCNw== X-Gm-Message-State: AKaTC02aqxLIC4Db4798M8uYCThmJWzVFJEZ5tuLoyxd4p3lgnQV04SB0p0uxTbObK80xo1IOQzb0a9mJIdhEuKE X-Received: by 10.194.126.38 with SMTP id mv6mr58448907wjb.142.1481113324505; Wed, 07 Dec 2016 04:22:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.19.73 with HTTP; Wed, 7 Dec 2016 04:21:44 -0800 (PST) In-Reply-To: <11053786.o6LJ0UWG8a@xps13> References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-11-git-send-email-hemant.agrawal@nxp.com> <6b58f8fa-4df0-684e-f1d3-4dc4dba4f0dd@nxp.com> <11053786.o6LJ0UWG8a@xps13> From: David Marchand Date: Wed, 7 Dec 2016 13:21:44 +0100 Message-ID: To: Thomas Monjalon Cc: Shreyansh Jain , Hemant Agrawal , "dev@dpdk.org" , "Richardson, Bruce" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 12:22:05 -0000 On Wed, Dec 7, 2016 at 11:40 AM, Thomas Monjalon wrote: > 2016-12-07 15:43, Shreyansh Jain: >> IMO, the way Bus is kept is debatable. >> - should it be in EAL (lib/librte_eal/linuxapp/eal_pci.c like Bus >> patches) [1]? >> - Should it a 'handler/driver' parallel to device drivers? >> >> I personally prefer a clean layer for buses with: >> >> - RTE_SDK/drivers/net/dpaa2/ >> - RTE_SDK/drivers/bus >> - RTE_SDK/drivers/bus/dpaa2/ >> - RTE_SDK/drivers/bus/dpaa2/dpaa2_bus.c etc. > > I agree, it is a good idea. Indeed. >> For PCI, which is generic (or for other similar generic buses, like >> platform), we can keep the implementation within lib/librte_eal/linuxapp/*. > > I would be in favor of moving PCI and vdev code from EAL to drivers/bus/. > We can keep the API in EAL and implement the buses as drivers. > > Other opinions? The only issue I see for now is how to pass the configuration to these drivers, like vdev args or the pci blacklist/whitelist. -- David Marchand