DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@6wind.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Xie, Huawei" <huawei.xie@intel.com>,
	 Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] virtio: fix modify drv_flags for specific device
Date: Tue, 3 May 2016 10:05:01 +0200	[thread overview]
Message-ID: <CALwxeUtsHp2gpWe2R3G2xKCqO3XUkTUCawwZs_6LDq2tWe2ffA@mail.gmail.com> (raw)
In-Reply-To: <1461866939-38689-1-git-send-email-jianfeng.tan@intel.com>

Hello Tan,

On Thu, Apr 28, 2016 at 8:08 PM, Jianfeng Tan <jianfeng.tan@intel.com> wrote:
> Issue: virtio's drv_flags are decided by devices types (modern vs legacy),
> and which kernel driver is used, and the negotiated features (especially
> VIRTIO_NET_STATUS) with backend, which makes it possible to multiple
> virtio devices have different versions of drv_flags, but this variable
> is currently shared by each virtio device.

The wording is a bit strange, maybe the sentence is a bit too long.
But the rest looks good to me.

Acked-by: David Marchand <david.marchand@6wind.com>

-- 
David Marchand

  parent reply	other threads:[~2016-05-03  8:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  2:24 [dpdk-dev] [PATCH] " Jianfeng Tan
2016-04-26 11:53 ` David Marchand
2016-04-27  5:10   ` Tan, Jianfeng
2016-04-27  5:20     ` David Marchand
2016-04-28 18:08 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2016-05-02 17:55   ` Yuanhan Liu
2016-05-03  8:05   ` David Marchand [this message]
2016-05-04 23:18     ` Yuanhan Liu
2016-05-09  9:14       ` Tan, Jianfeng
2016-05-09 18:01         ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALwxeUtsHp2gpWe2R3G2xKCqO3XUkTUCawwZs_6LDq2tWe2ffA@mail.gmail.com \
    --to=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=jianfeng.tan@intel.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).