From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 5BDDD2BB9 for ; Tue, 3 May 2016 10:05:21 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id a17so23908780wme.0 for ; Tue, 03 May 2016 01:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xSa88J74Z17hF96rAgHu6frn7KDnW/1UyE6Mjx26DD0=; b=Uk0CP5HqgXZwNhoocB9fkvgPNmeriuM5HDAEbYc/gj3doYoie0peCusmO6dpwi9puK GXZhz64QyfCMfJygSMdzCyJo6IwC/s6+nziIHfY54y1zX1CqkOqbyv3SXh6SAgll/Wti 0dBIUWoRxkl0uNT7HPja4vJf+DtiUf4alQ2Q7NzwYaq5adPariqp1SpYiHopw7gXytFb JRGDodUEcOUUd6Sqcv5bez4l09uzXViyD7cDAGY9BxH8p2+jyhVJG4b3kJ/k7JzhKaOb IDUJ+bAOEaNYQfw2MD6cHbb4iRyEK6jtiUVyHEC7tAjBH9NfHQGdZT0EwxTAWrSxXzzn a1aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xSa88J74Z17hF96rAgHu6frn7KDnW/1UyE6Mjx26DD0=; b=ORi4QNzETtreC+E5gm7QC+t4ico4EnMJLfLMv+wDmj+B4FvZO4EwN/fjinIEyzLcea BWk+iIqIhS+z1+q/bovLpLPL59reMWfXbelEOaCYw9bfebEkt4Bz/xDlcpljXPEDfSQC hlKqWWgW701OUjGssQ91E7vz/d0Ab+0Z+785OetqnvyG2x4EUKaVXox5s1ODNYoUMvDq ijfMTxqaqrbhw1COMfhXCOOXcIzRt7oKGTzYr5u1QyxKasxOhWgYuGdFIxkipJdUuY7z sGpUwWgHYJhyZWyisF7/tE3LyFqfIcn4dkzHwQ/fihHM86DKgw6cD2I+wxy0WeChJTeR Z47Q== X-Gm-Message-State: AOPr4FUH4bsduanrnDUAEGkTdWW1z4DSflSGB3v5QVDM1HhWbt31nn1nWXJVx8dFziXc5IDCuQD67/VN4QL/oK9x X-Received: by 10.28.27.17 with SMTP id b17mr1749450wmb.19.1462262721153; Tue, 03 May 2016 01:05:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.16.2 with HTTP; Tue, 3 May 2016 01:05:01 -0700 (PDT) In-Reply-To: <1461866939-38689-1-git-send-email-jianfeng.tan@intel.com> References: <1461637474-110602-1-git-send-email-jianfeng.tan@intel.com> <1461866939-38689-1-git-send-email-jianfeng.tan@intel.com> From: David Marchand Date: Tue, 3 May 2016 10:05:01 +0200 Message-ID: To: Jianfeng Tan Cc: "dev@dpdk.org" , "Xie, Huawei" , Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2] virtio: fix modify drv_flags for specific device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 08:05:21 -0000 Hello Tan, On Thu, Apr 28, 2016 at 8:08 PM, Jianfeng Tan wrote: > Issue: virtio's drv_flags are decided by devices types (modern vs legacy), > and which kernel driver is used, and the negotiated features (especially > VIRTIO_NET_STATUS) with backend, which makes it possible to multiple > virtio devices have different versions of drv_flags, but this variable > is currently shared by each virtio device. The wording is a bit strange, maybe the sentence is a bit too long. But the rest looks good to me. Acked-by: David Marchand -- David Marchand