From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 2E5125901 for ; Wed, 4 May 2016 10:27:10 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id a17so79823684wme.0 for ; Wed, 04 May 2016 01:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3A/RSmalSJ/8wCgADZNiOybdZ5Joz+amsxB9haggiyU=; b=NKfYn/SJrPfqVKX4Jxb5HUXCxtO06VXoeUscPQGaRp3i3pfnYtTt2cqLPndULFbv/t kgAAFmANdTHg4Pb4WAA1Sqg5Eygkp99/xHLp9Ll9W0XKLt/RfRI8QrulJwBOdu11/HTo vA5sOlN3ABhbQp9qV7v9/8QDYppEmZ3jkPPLYmjMKURGjZqzA+jJBfnMpVoN1mFjryK1 QVy9Bm7Orya7vV0ohSgORg/NQthiD0j128tsF9OYhb0XRsR7htsCFfLfziwk9Iwa7eCW icdK8AAT8wQhSna1knLlo74w2Mf8OTc0OXwpZOQkbEW0vUm5IFRX6yF/d73nIb16+0HG 2eMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3A/RSmalSJ/8wCgADZNiOybdZ5Joz+amsxB9haggiyU=; b=gWYmrl/WKsQO5f4hVCTpfmlIynd7ETxE8OqtTwpDS822pCsdwu3A22xwLPcu7dGSwa xPjTuZjAstyiTtqZw8b5t8JgA5kk4tIdhnEC76yIgbTPNIB7WOw2Q8abV5VM4Oe3zSyH e6slKUS64P/GEyDcFYp9GMaemR8cQ/bOG+iYWkQJg8ek/I9xqiS3zlBDAxY/SNAYCXeY IhFxgtnJJXH6TSN6+b4tKdoIfw+tZzcMj50LwKx1erDtGCV+8tg2P28Vm0PoT0Ssl+Pj XIK5Dxh/TQo9BHVbvOJow7JM42xotH1+3XP7v/9c0aRhaEsWeZGzZpagJYdQ039uCFNt Vc3A== X-Gm-Message-State: AOPr4FVf9o4qql6f2vqe6HwoYx0/0WEfbpnfRKbp1bE8/9Gu4gzozuxqaIKZIAUF2EqXlrpNNmtfCZieNqWDHp0P X-Received: by 10.194.14.130 with SMTP id p2mr7700441wjc.173.1462350429991; Wed, 04 May 2016 01:27:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.16.2 with HTTP; Wed, 4 May 2016 01:26:50 -0700 (PDT) In-Reply-To: <9BB6961774997848B5B42BEC655768F8E2883D@SHSMSX103.ccr.corp.intel.com> References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com> <1461156236-25349-1-git-send-email-david.marchand@6wind.com> <1461156236-25349-3-git-send-email-david.marchand@6wind.com> <9BB6961774997848B5B42BEC655768F8E2883D@SHSMSX103.ccr.corp.intel.com> From: David Marchand Date: Wed, 4 May 2016 10:26:50 +0200 Message-ID: To: "Wu, Jingjing" Cc: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "stephen@networkplumber.org" , "Richardson, Bruce" , "nhorman@tuxdriver.com" , "pmatilai@redhat.com" , "christian.ehrhardt@canonical.com" , "Zhang, Helin" , "Ananyev, Konstantin" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2016 08:27:10 -0000 On Fri, Apr 29, 2016 at 3:34 AM, Wu, Jingjing wrote: > Hi, David > > For the changes on igb, ixgbe, I saw you create a new header file called **__pci_dev_ids.h to replace the rte_pci_dev_ids.h for each driver. > But for the changes on i40e, you didn't do that way. > If you look into the base code, you will find for each Intel NIC, the device ids are defined there, such as ixgbe_type.h; i40e_devid.h; E1000_hw.h. > > I'd prefer the way you did in i40e driver. It's clearer and with minor change. This is what I wanted to do, but this requires a rework in kni and the pci test. -- David Marchand