From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com
 [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id 58547683D
 for <dev@dpdk.org>; Wed,  1 Apr 2015 07:23:18 +0200 (CEST)
Received: by obbec2 with SMTP id ec2so61782361obb.3
 for <dev@dpdk.org>; Tue, 31 Mar 2015 22:23:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=CXBo03pnArIOanJ9rwNl7i2W9zOrOfkZ3mWm1Ozp21Y=;
 b=RqjDe1vVg9fYIUyh/W4gyQRVnaJAQamhW28GoUmMUj03eGKzL01V3L3MQ32scSZ+IV
 fkBjzIYDzBhMbAG3quj34SBcLDHgbOn2gLcneN6J1oSvXNVuJNADdLFxnxPr82lEsKar
 6+1LKcabEM89OrHy19/TTmTodthDdcAlSqt/UBdl6eEjbeJI1165hAkBeR3j68hLaMF0
 dDRBk8bTf1xFmMTBm/QS3Oys4RxtSPm14exO9iYVOnr5VzHIhd3GJbLqZADeQshZSU/J
 QXDY1Q1AHTtQgo70ushXtilhK0JbfmKexgZlWt2wnzo6A5PV1HGZo9nANchN3wuaEu/T
 ymaA==
X-Gm-Message-State: ALoCoQnAF6a95IUgTP92WUe4DOxEZkl6NncVT4tQRJfmE65HDzeIi4+Y1YgpwVvocVbxHkwXftpt
MIME-Version: 1.0
X-Received: by 10.60.124.6 with SMTP id me6mr37627539oeb.46.1427865797645;
 Tue, 31 Mar 2015 22:23:17 -0700 (PDT)
Received: by 10.76.23.4 with HTTP; Tue, 31 Mar 2015 22:23:17 -0700 (PDT)
In-Reply-To: <1427839547-14705-1-git-send-email-thomas.monjalon@6wind.com>
References: <1427839547-14705-1-git-send-email-thomas.monjalon@6wind.com>
Date: Wed, 1 Apr 2015 07:23:17 +0200
Message-ID: <CALwxeUtxfcrU-gKyA37qZDCsWipE1mcaNS338yOsUuJB0YnPyQ@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] pci: rename passthrough driver to kernel
	driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Apr 2015 05:23:18 -0000

Hello Thomas,


On Wed, Apr 1, 2015 at 12:05 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> Kernel driver (kdrv) seems easier to understand than
> passthrough driver (pt_driver). It's also more generic
> as a PMD could run on top of any PCI kernel driver if
> it would offer such support.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  lib/librte_eal/bsdapp/eal/eal_pci.c     |  3 +--
>  lib/librte_eal/common/include/rte_pci.h | 12 ++++++------
>  lib/librte_eal/linuxapp/eal/eal_pci.c   | 33
> ++++++++++++++++-----------------
>  lib/librte_ether/rte_ethdev.c           |  8 ++++----
>  4 files changed, 27 insertions(+), 29 deletions(-)
>

This looks ok for me.
I suppose you checked it builds fine on both linux and bsd ?

Acked-by: David Marchand <david.marchand@6wind.com>

-- 
David Marchand