From: David Marchand <david.marchand@6wind.com>
To: Keunhong Lee <dlrmsghd@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Bugs in newest patches
Date: Fri, 7 Nov 2014 07:14:55 +0100 [thread overview]
Message-ID: <CALwxeUu2Jg4=A6VaVU5=zOqH-jvacyOf_M6KXHkw81eWpah98w@mail.gmail.com> (raw)
In-Reply-To: <CAKBXKmD7qRTHU-VmdNMAvpTnAAMuD5ZxTqoj5VUr3v4FKa6XTw@mail.gmail.com>
Hello,
On Fri, Nov 7, 2014 at 2:26 AM, Keunhong Lee <dlrmsghd@gmail.com> wrote:
> I did not included the generic header directly.
> I thought that this nested "extern C" is intended,
> however, according to your reply, this might be removed at all.
>
> There is a remaining
> """
> #ifdef _cplusplus
> }
> #endif
> """
> at the end of "generic/rte_cycles.h".
> I think this should be removed. This causes compile error on C++.
>
Argh, good catch.
I will send a fix (it looks to be the only one remaining).
--
David Marchand
next prev parent reply other threads:[~2014-11-07 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 20:21 Keunhong Lee
2014-11-06 21:05 ` Thomas Monjalon
2014-11-07 1:26 ` Keunhong Lee
2014-11-07 6:14 ` David Marchand [this message]
2014-11-07 6:26 ` [dpdk-dev] [PATCH] eal: fix C++ compilation issue after headers rework David Marchand
2014-11-07 11:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUu2Jg4=A6VaVU5=zOqH-jvacyOf_M6KXHkw81eWpah98w@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=dlrmsghd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).