From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com
 [209.85.218.53]) by dpdk.org (Postfix) with ESMTP id 7CA8912A8
 for <dev@dpdk.org>; Mon, 19 Jan 2015 08:21:23 +0100 (CET)
Received: by mail-oi0-f53.google.com with SMTP id g201so25517989oib.12
 for <dev@dpdk.org>; Sun, 18 Jan 2015 23:21:22 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=e878/fFFIargLKR4FVBpnwiYUOYn5GjdKaTl1Aan6d8=;
 b=foS9PW1SOT0qZV8BbY/tEeY9a9XVpXZidAF7H7BZCeWuSqfcQEpLXR6ADVVNSA9rp3
 HSEcGYTWoh11IilBAYUQVDIVA8W/Z76DInEy1MhMOxXY9QEumR+RSFWjuD0/waN7fQhd
 aEbmWfSwIFE6kVR+tO8HZw0bhnSV4pkQPEjSd3OFUT0pQKJxcP7atlCSl5lq+KtUCWk8
 B3ScS6lyrbhlGP9ruEAwotnFj9B483FoJhUIP0M+yFjjw4pLbqX+wpvh7LzQ3AnVTCyc
 c99Z/Z9Z2dSlNcq9tcp0rFZWdbY1aUEnGUEE80lWoHjku//Y05UtlHd9lgmBbItZY9rD
 603Q==
X-Gm-Message-State: ALoCoQm5y/rrSUJ9h5BRmrGxjWQZcMbojoF8NwEIOelO7TpnwiGJ5PU6yzZqbmiNuTgFuc7R3cJr
MIME-Version: 1.0
X-Received: by 10.60.98.204 with SMTP id ek12mr17064058oeb.14.1421652082732;
 Sun, 18 Jan 2015 23:21:22 -0800 (PST)
Received: by 10.76.95.198 with HTTP; Sun, 18 Jan 2015 23:21:22 -0800 (PST)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EA935@SHSMSX104.ccr.corp.intel.com>
References: <1419694115-1892-1-git-send-email-rkerur@gmail.com>
 <1419694244-2018-1-git-send-email-rkerur@gmail.com>
 <20141227204903.GB16138@localhost.localdomain>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EA935@SHSMSX104.ccr.corp.intel.com>
Date: Mon, 19 Jan 2015 08:21:22 +0100
Message-ID: <CALwxeUu2YOFUeQ3urHxFk+3mYef0zyiZMCDnYTsiJ7o9K0Pzhw@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2015 07:21:23 -0000

Hello,

On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin <helin.zhang@intel.com> wrote:

> It seems that your fix result in cannot launching applications.
> I don't suspect the correction of your fix, but somewhere else needs to be
> corrected together with your fix.
>
> Logs:
> /************************************************************
> RING: Cannot reserve memory for tailq
>

I have a quick fix for this one (rte_malloc_socket refuses 0 alignment),
but looking at the change, I would say there are a lot of places to be
checked.
Were those places checked during review ?

Kerur, did you run a make test ?
All tests fail for me because of rte_malloc_socket.


-- 
David Marchand