From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id A327468AC for ; Mon, 1 Dec 2014 21:07:45 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id a141so8030674oig.9 for ; Mon, 01 Dec 2014 12:07:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=k1mVjUQ26SGZZT53kJNn96SQmlzwnwu/zl/TyxNBlkM=; b=AjC6zFOEY9w94wxJXcFFDWthn0Sz60kMpiobtDLmwt2lO5Igri2ESUje1rluMLtiYv oABLWfYltzmM+JdIljUhAUW5jEzv3slmhUXGzaEJ8Wyccbo9OpMNQk4W3X4iGal5i8K5 OKHHAvLbXn+YXSGCywsOR4aFgkiNmoVGRzP6BixEKJQMW3cTQpt+xEsgwRRXH63YYj35 7WcNNKsjDFNDhzEHtBcLmTjOF3ulRadHZtfv+bvdgp/LG2RHlV2i2+aRLdNIcvR5ZSbD CFYYajcEHuTqT6Cypbqp6rAg4HmZkYDE7KGWjdVNJKMDyBIu9Mm4CJUOZ7YQhD/KhG8U mmdQ== X-Gm-Message-State: ALoCoQl+pfic93WkvENiU7OaDTmQt2r0/A1+KIEDU9lGGtFv4DHIeb8ZGmxYq6G75x3+AbUV+DLg MIME-Version: 1.0 X-Received: by 10.183.24.129 with SMTP id ii1mr35158159obd.34.1417464464905; Mon, 01 Dec 2014 12:07:44 -0800 (PST) Received: by 10.76.172.165 with HTTP; Mon, 1 Dec 2014 12:07:44 -0800 (PST) In-Reply-To: <1417455659-24854-1-git-send-email-thomas.monjalon@6wind.com> References: <1417455659-24854-1-git-send-email-thomas.monjalon@6wind.com> Date: Mon, 1 Dec 2014 21:07:44 +0100 Message-ID: From: David Marchand To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with bypass and debug enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 20:07:46 -0000 On Mon, Dec 1, 2014 at 6:40 PM, Thomas Monjalon wrote: > Since commit aae1047905621 ("use the right debug macro"), > DEBUGOUT was replaced by PMD_DRV_LOG which requires at least > 2 arguments. But the level argument was missing. > > Commit 7a10de5e27 fixed the logs but not the macros FUNC_PTR_OR_* > which are not preprocessed if RTE_LIBRTE_IXGBE_DEBUG_DRIVER is disabled. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_pmd_ixgbe/ixgbe_bypass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_bypass.c > b/lib/librte_pmd_ixgbe/ixgbe_bypass.c > index 15203a4..832f415 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_bypass.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_bypass.c > @@ -42,7 +42,7 @@ > /* Macros to check for invlaid function pointers. */ > #define FUNC_PTR_OR_ERR_RET(func, retval) do { \ > if ((func) == NULL) { \ > - PMD_DRV_LOG("%s:%d function not supported", \ > + PMD_DRV_LOG(ERR, "%s:%d function not supported", \ > __func__, __LINE__); \ > return retval; \ > } \ > @@ -50,7 +50,7 @@ > > #define FUNC_PTR_OR_RET(func) do { \ > if ((func) == NULL) { \ > - PMD_DRV_LOG("%s:%d function not supported", \ > + PMD_DRV_LOG(ERR, "%s:%d function not supported", \ > __func__, __LINE__); \ > return; \ > } \ > > > Argh ... good catch. Looks like these were the only places with this error (I did some grep and only found those). And ok with the ERR level, it looks fine to me. Ack. Thanks Thomas. -- David Marchand