From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com [209.85.161.193]) by dpdk.org (Postfix) with ESMTP id 6FC6E3238 for ; Fri, 13 Jul 2018 13:29:08 +0200 (CEST) Received: by mail-yw0-f193.google.com with SMTP id l189-v6so11597097ywb.10 for ; Fri, 13 Jul 2018 04:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2ibgTBVRKB41iuyF9KFg2vWn/bH2QXbnoch/Ph3vtSs=; b=F1R2wfYuzC1WVvUp1t0KyO+oWq3IQA8CshtjK0bKOV9ZeQuoGR6Jy7ydHQ4LVLtF0p /YjXoiPtw9aBuk1kyWmcuJ3JEeHCooxO4vQZQcbcDuODh79p4stpAUc3gKfVyMNfFqbD IBoM/DsCp6ndJL+91UT+p1Zg1AyXOyuCOv9/E11mf8z19CshmM7C4TWqzS0/4EIjpKCX 8a0a2VkZkXQsPJZey5p9UWa+AJJqk7cKxH7N3MnFeNlTBdLS+kqKuqx133XC3Jw+Lme3 iXdi8yJSe4ajXyXu7pmbYMskWF3H5n/kbthr3/wbNKOptFtOlYyOIFF5tTiAYDQawpa9 eIrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2ibgTBVRKB41iuyF9KFg2vWn/bH2QXbnoch/Ph3vtSs=; b=Gk3CDHy4kF5P16L05ldoU0LMb+uNEwI2EfOlE9bxqewgVLKoGsZCI4DdZlWVtsy83M 2Y4yhxU+atKwBX8m2s+mgcmfQryAVs3Lrlbl8Ttw7y9RQPej1PLdgNPwXgipQXrLZAkr 1BnV4rsqORZZs30zTWHm7J3ee7xfyD6KORceoMoCrhoIU9rya5g+QLs7cUR+6GDGRfx6 SRppP+zaWm63+A0LWkqNIdTOLVNLoC3uKm2MVN3L8ZptUdd8MJDdyhhhqinHM6zo3qbl cpo7mhY77vFCc/LWJBkKyGEziJVdTECb+osKgdkpEFzJ07Jv55vF7p/MqFc79ch/0x94 xCFQ== X-Gm-Message-State: AOUpUlEaD/KeqmNLJLe+I1xdt0T6SE4IpgqlIjZCR+iHDAKv/0Gj9TcB JNaXY/inA9xQtceCnBG5THAqNW24kqlnNpeae9oogQ== X-Google-Smtp-Source: AAOMgpfF6XC8OekU6C5gVjJvcWUGyb6G9RCzrHmFYMEHYRCCtWfgMzGr1/iI0+Iv/eTPjk/ZCyIiITnf/Q4vBdQ6T0w= X-Received: by 2002:a81:5155:: with SMTP id f82-v6mr3014575ywb.221.1531481347704; Fri, 13 Jul 2018 04:29:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:a282:0:0:0:0:0 with HTTP; Fri, 13 Jul 2018 04:28:47 -0700 (PDT) In-Reply-To: <20180713091042.GA21549@debian> References: <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com> <5431396.k1M6VaMcRs@xps> <20180713091042.GA21549@debian> From: David Marchand Date: Fri, 13 Jul 2018 13:28:47 +0200 Message-ID: To: Tiwei Bie Cc: Thomas Monjalon , Anatoly Burakov , dev@dpdk.org, Jianfeng Tan , Bruce Richardson , "Ananyev, Konstantin" , qi.z.zhang@intel.com, Stephen Hemminger , Olivier Matz , Ferruh Yigit , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 11:29:08 -0000 On Fri, Jul 13, 2018 at 11:10 AM, Tiwei Bie wrote: > On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote: > [...] >> Well, there was an issue vith virtio at one time (interrupt handler >> did not have the right iopl for virtio callback). >> http://git.dpdk.org/dpdk/commit/lib/librte_eal/linuxapp/eal/eal.c?id=fd6949c55c9a48e81c625138679159829d51ac51 >> >> Now... time has passed since then. >> It is worth checking the issue is still here, and if it is the case, >> revisit this. > > Now rte_virtio_pmd_init() which calls rte_eal_iopl_init() > is called as a constructor [1], so the issue isn't there > any more. If the virtio pmd is loaded dynamically, eal_plugins_init() is still called before rte_eal_intr_init(). Yes, for this case, it looks to be fine with Anatoly change. -- David Marchand