From: David Marchand <david.marchand@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Julien Meunier <julien.meunier@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] igbvf: fix vlan filtering
Date: Mon, 2 Nov 2015 17:32:31 +0100 [thread overview]
Message-ID: <CALwxeUuBAG19wbu574qgdWdXGHzrtKJccYtmaiAZKUPFedGM9g@mail.gmail.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A545A@shsmsx102.ccr.corp.intel.com>
Hello,
On Mon, Nov 2, 2015 at 8:21 AM, Lu, Wenzhuo <wenzhuo.lu@intel.com> wrote:
>
> > @@ -2502,7 +2503,14 @@ static int igbvf_set_vfta(struct e1000_hw *hw,
> > uint16_t vid, bool on)
> > if (on)
> > msgbuf[0] |= E1000_VF_SET_VLAN_ADD;
> >
> > - return (mbx->ops.write_posted(hw, msgbuf, 2, 0));
> > + mbx->ops.write_posted(hw, msgbuf, 2, 0);
> How about if write failed? I think we'd better check it.
>
Yes, just trying to test this before resubmitting.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2015-11-02 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 16:14 David Marchand
2015-11-02 7:21 ` Lu, Wenzhuo
2015-11-02 16:32 ` David Marchand [this message]
2015-11-03 14:25 ` [dpdk-dev] [PATCH v2] " David Marchand
2015-11-04 2:00 ` Lu, Wenzhuo
2015-11-10 16:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUuBAG19wbu574qgdWdXGHzrtKJccYtmaiAZKUPFedGM9g@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=julien.meunier@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).