From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f171.google.com (mail-ob0-f171.google.com
 [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id D3D31591F
 for <dev@dpdk.org>; Mon,  2 Nov 2015 17:32:31 +0100 (CET)
Received: by obbwb3 with SMTP id wb3so99198336obb.0
 for <dev@dpdk.org>; Mon, 02 Nov 2015 08:32:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind_com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=zx5oZF3wCO3CcuJ2+yDx6BL8pBQPRGiESKvGyAWTLnU=;
 b=zhuJzaSjZMgk3UEaS8QYJYCvfYdqaWyFwho3CffoOBNy5yactjECe8Titm2lef1dx8
 55G2l6iM/s6XThiqY4CiOme5tDBxt8BeEIdo+L4lW5NzRI8pi1RNwA39sv7zOQ33vtCq
 T2SY8R08s4/H7/doXWy9y7oj0lzZbNT4sOrxMktlGwnGSIFqvE3ynYfiQr+I2u8vn5Ms
 kR6S3bGW/++A93r7Qi4fozAR7VQH6xgrC/2rZDvCh1Zbbd4YRbCPNAKaIhNLrrh4kjkH
 4UzuCJoQ90YqElVIxjWTHaRRqkcTvK4GeloHsolfhdVWePOfnflvgjvZxPqzr8CMPMMB
 +Pmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=zx5oZF3wCO3CcuJ2+yDx6BL8pBQPRGiESKvGyAWTLnU=;
 b=XVWlnuuCH575i1wLD6Xh2s7MhFbbNm5Y4rsUJrcngT131Mbpk/pYmol4nEssPLRxK3
 +avkQhJkuICjYSXuqRQsqtH0Mht1P1fPVDq3XVAiDm4tVxSp2m0FTniPxdjptu/j4McB
 SMoj0PzkTEuAcCT1HOypBBn9rpQ0fpYQ+PEpFqP0mjG0XPhhmZShT8y3fmy3Lcv3oOeY
 dnJbR6aRjdliVAyt9mMs5Bd0hi+DSTtxtqQdSlKDRZr1GIPADl/8Pv5tGwln0j/GHCJf
 sJI592QXXYrmigw3sXlEOYgGWXSXmzQ2SMYotR/EZNblDOzjx8QC+p9cdBVZdlKcNIv2
 mLag==
X-Gm-Message-State: ALoCoQn/NzLdyU+I+3gK85nsR6SMUZrzjstAQfVpEnXmmVSdZKuQWX7Q80XI0t6oytA/WcoxXHZj
MIME-Version: 1.0
X-Received: by 10.60.140.228 with SMTP id rj4mr15645872oeb.15.1446481951306;
 Mon, 02 Nov 2015 08:32:31 -0800 (PST)
Received: by 10.76.131.166 with HTTP; Mon, 2 Nov 2015 08:32:31 -0800 (PST)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A545A@shsmsx102.ccr.corp.intel.com>
References: <1446221643-10763-1-git-send-email-david.marchand@6wind.com>
 <6A0DE07E22DDAD4C9103DF62FEBC0909020A545A@shsmsx102.ccr.corp.intel.com>
Date: Mon, 2 Nov 2015 17:32:31 +0100
Message-ID: <CALwxeUuBAG19wbu574qgdWdXGHzrtKJccYtmaiAZKUPFedGM9g@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>, Julien Meunier <julien.meunier@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] igbvf: fix vlan filtering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 16:32:32 -0000

Hello,

On Mon, Nov 2, 2015 at 8:21 AM, Lu, Wenzhuo <wenzhuo.lu@intel.com> wrote:

>
> > @@ -2502,7 +2503,14 @@ static int igbvf_set_vfta(struct e1000_hw *hw,
> > uint16_t vid, bool on)
> >       if (on)
> >               msgbuf[0] |= E1000_VF_SET_VLAN_ADD;
> >
> > -     return (mbx->ops.write_posted(hw, msgbuf, 2, 0));
> > +     mbx->ops.write_posted(hw, msgbuf, 2, 0);
> How about if write failed? I think we'd better check it.
>

Yes, just trying to test this before resubmitting.

Thanks.


-- 
David Marchand