From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id A7D9C58EE for ; Tue, 2 Sep 2014 16:12:24 +0200 (CEST) Received: by mail-ob0-f178.google.com with SMTP id uy5so4812967obc.23 for ; Tue, 02 Sep 2014 07:16:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=EuzF4a6QJHcy8CdJX9nheVXlYNKSgTQTboAmzB6hluw=; b=hSCo9pd1DrgN8tWMcXTb1/DBvV+9AsxYmVCUsUTNwAG1VuKTtPv7jNMFeiXHWZkDnN gMh862KABJW8YpAttpG/1HlWlKyF/dhhaWh3vniwkTe1f8Q/f7ovramYpuYEOSkpUixE CypRN7d9lbAqlgbYL7gNCaVGRgEiVWm4bRPFBbPHZjn5lq3kk/zqF3OSkpfGKEfDzdgM hCUj+kmN+MroCYB2D9w7Q/2BJ1MuzxQGiD7RTWKd1ya6GTlPkCCKfN9vMLuLdw+A2JHu 8lVKvP3rPVeMyQqd1wpVBPvz5QRFYQCcE5xmaCRChdeEUkoz92ypbDFQ/rKRt7bZGDSr Karw== X-Gm-Message-State: ALoCoQls4bAGcISWBJWFX/zpr8q9RCVwEiU9R8IcpvczNH0DOK1qbOY52d9z1tHd3R3hkZSgqljh MIME-Version: 1.0 X-Received: by 10.60.156.198 with SMTP id wg6mr2353099oeb.69.1409667415844; Tue, 02 Sep 2014 07:16:55 -0700 (PDT) Received: by 10.202.73.74 with HTTP; Tue, 2 Sep 2014 07:16:55 -0700 (PDT) In-Reply-To: References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com> <1409567080-27083-2-git-send-email-david.marchand@6wind.com> Date: Tue, 2 Sep 2014 16:16:55 +0200 Message-ID: From: David Marchand To: Jay Rolette Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 14:12:25 -0000 Hello Jay, On Tue, Sep 2, 2014 at 3:43 PM, Jay Rolette wrote: > > On Mon, Sep 1, 2014 at 5:24 AM, David Marchand > wrote: > >> >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_bypass.c >> b/lib/librte_pmd_ixgbe/ixgbe_bypass.c >> index 1d21dc0..1a980b8 100644 >> --- a/lib/librte_pmd_ixgbe/ixgbe_bypass.c >> +++ b/lib/librte_pmd_ixgbe/ixgbe_bypass.c >> @@ -40,20 +40,20 @@ >> #define BYPASS_STATUS_OFF_MASK 3 >> >> /* Macros to check for invlaid function pointers. */ >> -#define FUNC_PTR_OR_ERR_RET(func, retval) do { \ >> - if ((func) == NULL) { \ >> - DEBUGOUT("%s:%d function not supported\n", \ >> - __func__, __LINE__); \ >> - return (retval); \ >> - } \ >> +#define FUNC_PTR_OR_ERR_RET(func, retval) do { \ >> + if ((func) == NULL) { \ >> + PMD_DRV_LOG("%s:%d function not supported", \ >> + __func__, __LINE__); \ >> + return retval; \ >> > Need to keep the parens around retval in your macro > Actually, checkpatch complained about this. So I can keep the parenthesis, but then I don't want Thomas to tell me my patch does not pass checkpatch :-) > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >> index dfc2076..46962bc 100644 >> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >> @@ -1765,33 +1765,36 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, >> tx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ? >> tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH); >> if (tx_rs_thresh >= (nb_desc - 2)) { >> - RTE_LOG(ERR, PMD, "tx_rs_thresh must be less than the >> number " >> - "of TX descriptors minus 2. (tx_rs_thresh=%u >> port=%d " >> - "queue=%d)\n", (unsigned int)tx_rs_thresh, >> - (int)dev->data->port_id, (int)queue_idx); >> + PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than the >> number " >> + "of TX descriptors minus 2. (tx_rs_thresh=%u >> " >> + "port=%d queue=%d)\n", (unsigned >> int)tx_rs_thresh, >> > Embedded newline on this log message. I noticed you have \n still on all > of the PMD_INIT_LOG() calls following. Intended? > Yep intended, a patch after this removes all \n (idem for the other comments). Thanks. -- David Marchand