Re: [dpdk-dev] [PATCH] eal: prevent dereferencing NULL pointer in rte_eal_devargs_add()

[David Marchand <david.marchand@6wind.com>]

Hello Pawel,

On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski <pawelx.wodkowski@intel.com
> wrote:

> On failure devargs->args should not be accesed if devargs is NULL.
>

accessed.


>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> ---
>  lib/librte_eal/common/eal_common_devargs.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_devargs.c
> b/lib/librte_eal/common/eal_common_devargs.c
> index 9b110f7..615945e 100644
> --- a/lib/librte_eal/common/eal_common_devargs.c
> +++ b/lib/librte_eal/common/eal_common_devargs.c
> @@ -124,12 +124,13 @@ rte_eal_devargs_add(enum rte_devtype devtype, const
> char *devargs_str)
>         return 0;
>
>  fail:
> -       if (devargs->args)
> -               free(devargs->args);
>         if (buf)
>                 free(buf);
> -       if (devargs)
> +       if (devargs) {
> +               free(devargs->args);
>                 free(devargs);
> +       }
> +
>         return -1;
>  }
>
>
Fixes: c07691ae1089 ("devargs: remove limit on parameters length")
Acked-by: David Marchand <david.marchand@6wind.com>

-- 
David Marchand