From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com [209.85.218.53]) by dpdk.org (Postfix) with ESMTP id 1E833AD9D for ; Tue, 24 Feb 2015 13:39:47 +0100 (CET) Received: by mail-oi0-f53.google.com with SMTP id u20so19004695oif.12 for ; Tue, 24 Feb 2015 04:39:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=pIviqIa6pkdgmzhJhDlwHZRp8pHf+2ESXiXdnMY0DSE=; b=Ik8LK0rK7PA056RcQNoCRrTQoxVKxfEfnTKjDZ1zuM+oj3H7d4jUrytZbwOioAPtOm bC1+9uKaiGQ6tWqyJIVmbASucL7irsSyzk0GclL50a4ojP5KvnJIb2bS0VvLKr1q4T0m 39QAVk3YtkQuYmLLDzDkd6fVtNTfXVEIz0T0AKaWme/1pS0FnDtTR9Puxj5hCqy8RFlh 4ETT7s61VXX5e1K3dsAWVK2fjbQW/nbtlvtboLfuuoV2ucScpbBTi42PNnkscpVuPJ6K D9LQjzVkUsUzvYPucLPDIEUk1gLrpf7dzYzvhJsr1KPS7H3JUeyO1qnhQos1R9K+64bu 4NJw== X-Gm-Message-State: ALoCoQnFx0hQ1g/s5Qddpac7B7JYTdTe6d200SodZCcsmY0NTl+Bz/jHIZcwzJFWm40vAq4oZ+Ot MIME-Version: 1.0 X-Received: by 10.60.42.211 with SMTP id q19mr10865367oel.58.1424781586636; Tue, 24 Feb 2015 04:39:46 -0800 (PST) Received: by 10.76.133.162 with HTTP; Tue, 24 Feb 2015 04:39:46 -0800 (PST) In-Reply-To: <1424780404-30824-2-git-send-email-bruce.richardson@intel.com> References: <1424703444-30761-1-git-send-email-bruce.richardson@intel.com> <1424780404-30824-1-git-send-email-bruce.richardson@intel.com> <1424780404-30824-2-git-send-email-bruce.richardson@intel.com> Date: Tue, 24 Feb 2015 13:39:46 +0100 Message-ID: From: David Marchand To: Bruce Richardson Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: mmap uio resources using resourceX files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 12:39:47 -0000 On Tue, Feb 24, 2015 at 1:20 PM, Bruce Richardson < bruce.richardson@intel.com> wrote: > Instead of distinguishing the BAR mappings via offset within a single > file, originally /dev/uioX, switch to mapping each individual bar via > the appropriately numbered resourceX file. > > Signed-off-by: Bruce Richardson > --- > lib/librte_eal/common/include/rte_pci.h | 2 +- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 34 > ++++++++++++++++-------------- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > 4 files changed, 21 insertions(+), 17 deletions(-) > As long as igb_uio / uio_pci_generic both work, this is fine for me. ack. -- David Marchand