From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 146528E8D for ; Mon, 4 Jan 2016 10:01:09 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id o124so251510299oia.1 for ; Mon, 04 Jan 2016 01:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ionH4MxzWtA+o3ijQ83cBGCqROuNxlWsV00BtfxlKuw=; b=m0L4Kbyb4CzUBybX/pe/iyGxRHCsNda09ibWB9AaJiurtXHApNbJMRzbVq2ohRudzE QYdUtX2RcEvxWqYEnNmGBJ4sUtmT82BlKhyvzIs14YT6hPApkYTNHBh7HfgwgBPsfwpY g0vEW+ZI5KB/qsRRh+p0HPSTBTar3K48kb+C2GXBRdCxJGNsLWwlwNwBmC34Afm+ZRz5 cRMBpIjlB5b6YS3mSxe7jXvbO/3b0Lm2EklRTNKTgFAsPuZ/6FRBTFzRMxWzLnDZ/wF1 gyPDCYUP+lqlQVVi6QZNKIhmTvsNeOxkDbD+phzQeKsusPbggFiELdnFTTsaK/6aP9sw z9VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ionH4MxzWtA+o3ijQ83cBGCqROuNxlWsV00BtfxlKuw=; b=QWogsFuXF72Wuw/tIHNDflb9WI3qsEpEgxJeL0dgZcflVwJu2Px6SnvWvj9F5XWWVE ui5pxFPqc+nMwcjkBEw/fTE+CGyQZ5lmrF2oy0qWhzGAQHTcu7vACKq84DQgAMZq8wY7 tqITt3I8sB4xevS0uyNkkZVNpkii11qdmvb1gvPs9tq21Dp1kzeT0G5ANj161bFnvAqC 9UgYoltsztAmbU3ddo7KDs2hvkqq0oh4svBuFvJiVaGKh2v5AXq5l2bnKbS9uyi9D7OU V8wdD6u5PZfB380giwYiNBhvnCwSUxb3tptYTMbkkodc/WgYrSil7Ruw/Yc5PTG6teof C4Wg== X-Gm-Message-State: ALoCoQkd9Hfm7GjnUDhlgeM3fP6IW2nAZIOmP99claymBWKKawk9+XOmliccn0faM3kPlPB1FqwL6c8QyHbe6s9yyTJSKE6sG4GuShVIe3NAUGALQgAytdI= MIME-Version: 1.0 X-Received: by 10.202.208.65 with SMTP id h62mr57670407oig.57.1451898068341; Mon, 04 Jan 2016 01:01:08 -0800 (PST) Received: by 10.76.153.5 with HTTP; Mon, 4 Jan 2016 01:01:08 -0800 (PST) In-Reply-To: References: Date: Mon, 4 Jan 2016 10:01:08 +0100 Message-ID: From: David Marchand To: Yi Lu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2016 09:01:09 -0000 Hello, Four mails for this ? :-) Please test off-list when you are not sure how to send patches. On Sun, Jan 3, 2016 at 3:49 PM, Yi Lu wrote: > Error message: > /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function > =E2=80=98rte_eal_hpet_init=E2=80=99: > /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: > implicit declaration of function =E2=80=98rte_thread_setname=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > ret =3D rte_thread_setname(msb_inc_thread_id, thread_name); > ^ > /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: > nested extern declaration of =E2=80=98rte_thread_setname=E2=80=99 [-Werro= r=3Dnested-externs] > cc1: all warnings being treated as errors > > Fixes: badb3688ffa8 ("eal/linux: fix build with glibc < 2.12") > Well, this problem was not seen before as you need to enable hpet support. Title and commitlog should, at least, mention hpet. > Signed-off-by: Yi Lu > --- > lib/librte_eal/linuxapp/eal/eal_timer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c > b/lib/librte_eal/linuxapp/eal/eal_timer.c > index 9ceff33..bcadf09 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_timer.c > +++ b/lib/librte_eal/linuxapp/eal/eal_timer.c > @@ -50,6 +50,7 @@ > #include > #include > #include > +#include > #include > > #include "eal_private.h" > Initial patch preferred eal_thread.h inclusion, but since rte_thread_setname is defined in rte_lcore.h, I am fine with your patch. So ack once the commitlog mentions hpet. Thanks. --=20 David Marchand