From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 52E59137C for ; Fri, 30 Sep 2016 16:33:12 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id t81so41057377lfe.0 for ; Fri, 30 Sep 2016 07:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/0JjS4YGKsllzHgKAZuHRRxUSosJZFKK/WozpYpsos4=; b=FOlOnvK4TyRsIpDwGXTgB3BIuHrxyh8a5oSxnLBscQabTieR6bfKFr6RC6mw4P4cGj oKWBT3GARb3xHiTdRgn9eI+gb0B93FcBk/HNAuGFis+/+2DKL/bTjzc3GPy7XEI3AIWG 7L5kJ+9jGJjofsI2bDMleLF7w5Y/MJldaB6+qSlyti2xmCUT3YPI2e1SrxrexEdPcaCf mfibceok7E4L5FVx1l+9C+5FzqcneACgBWvB1jeO5b5Z8n5KoRvpxkNh8zNtnPqAl7SZ AFqsSvU3EiF14mOAFq+OOSN3v2NMYJDxBz+yjmmUIcO8QOA1yWPLMhADG5RUiLjPC/L+ UNSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/0JjS4YGKsllzHgKAZuHRRxUSosJZFKK/WozpYpsos4=; b=NBWX61zlh8IFmUH+W39cib2ujQkRJOUrLoEVkccypPg7H6uR6+q7U99bABs5TY5D1z T3lwSp1/zll1G2v1xTiPEoayIX904s/poh5zDfQa8Hm6CZ7z2SbciSN8MMZQkZt2TSAZ 02cAUdHR6GVJBhT5c4nqrUIWNjN9zok/lU/OIdq0YuR76EzrM1I1f2zz3ilLDLNLk9/Z JT9eUQMlXKIol7VLzpkz9j6jeePWuCGRMSTQS/1pvbTqsgD3PQVAbUB8VnAPPUOQ6nls RmJ/SvslFjiHqSQrNCik3aI5XyPP8BedCUIc/Mcj6MyrtEoubZDdH9FLFpe4AVQyXnJK fN8Q== X-Gm-Message-State: AA6/9RklR+IrywSAOFgjl3FC1LouzYOeqbxcBpxCZfv+ipA8r1sHmKCtAe1VTa9zDmj4Wqb/9m8lvzDKtrrefQw1 X-Received: by 10.194.104.106 with SMTP id gd10mr7451927wjb.26.1475245991937; Fri, 30 Sep 2016 07:33:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.95.130 with HTTP; Fri, 30 Sep 2016 07:32:51 -0700 (PDT) In-Reply-To: References: <1474614646-23648-1-git-send-email-yuanhan.liu@linux.intel.com> <3786074.FTf50R74LC@xps13> <20160923091448.GB23158@yliu-dev.sh.intel.com> From: David Marchand Date: Fri, 30 Sep 2016 16:32:51 +0200 Message-ID: To: Yuanhan Liu Cc: Thomas Monjalon , "dev@dpdk.org" , Sergio Gonzalez Monroy , "Tan, Jianfeng" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] eal: remove single file segments related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 14:33:12 -0000 On Fri, Sep 23, 2016 at 12:08 PM, Tan, Jianfeng wrote: >> -----Original Message----- >> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] >> Sent: Friday, September 23, 2016 5:15 PM >> To: Thomas Monjalon >> Cc: dev@dpdk.org; David Marchand; Tan, Jianfeng >> Subject: Re: [PATCH] eal: remove single file segments related code >> >> On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote: >> > 2016-09-23 15:10, Yuanhan Liu: >> > > Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") >> > > removed ivshmem support, but seems David forgot to remove the another >> > > piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is >> introduced >> > > when ivshmem was firstly added. >> > >> > It is not a mistake. We thought it is used by container use case. >> >> I think no. It would help the container case a bit, but not too much I >> would think, especially when the memory goes fragement. >> >> Jianfeng, IIRC, you don't use that option for container case, right? >> >> --yliu > > No, I don't use this option for container case. As yuanhan said, it cannot provide much help for virtio_user memory region number limitation. Ok, as said, since this feature had been introduced with ivshmem 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"), if Sergio has nothing against this removal, I am all for removing unused code. -- David Marchand