From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id E0DCB231C for ; Fri, 28 Nov 2014 16:41:07 +0100 (CET) Received: by mail-ob0-f182.google.com with SMTP id m8so5146956obr.41 for ; Fri, 28 Nov 2014 07:41:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4iuo671xu3L7/JJQwieNvg/da8L2sdCInjbRdMgTtWY=; b=LvXFULHpTel479yZg6tdT3N+r9xaoF62i8XRwic4E3pgYWrUZZUBLYTF1vXsBH3apo 0ld5m2zDpymTTzuOFVaavYSbMd1+RmwJpP2faJlGwsdnS2cPdrZG0hG/UhQZubxnVL+n Aa53MqcBdU2p2CCt5dgxyjBdTvP7ppe1wVvAhVM1VD0I1pTsLeuQWkPCG5pgE3MRNeXk TdcVpJsqCB9GN0w0J7ExzCSNCCdV4V+lfOIJUpf2zbcMtyuWQY4+VoXMP8Bh1MnXaddz fxzjIAKU1MAjz7Xyt7IeY4YCtwBxxTKwLnjTCXKodoD/inh61JuyG417OXeXavtzVtBB dX6A== X-Gm-Message-State: ALoCoQkH6ahJP1ZftEe6hQpntR5mYG8nf+l8PzRWHKv9F90vLsjYEgkxDZpfj8qnKTpcqnj4YPKb MIME-Version: 1.0 X-Received: by 10.60.48.106 with SMTP id k10mr8598351oen.56.1417189267200; Fri, 28 Nov 2014 07:41:07 -0800 (PST) Received: by 10.76.172.165 with HTTP; Fri, 28 Nov 2014 07:41:07 -0800 (PST) In-Reply-To: <20141128145920.GC3412@bricha3-MOBL3> References: <1417087745-9004-1-git-send-email-david.marchand@6wind.com> <4256507.tIOyuODinC@xps13> <20141128135604.GB5828@bricha3-MOBL3> <20141128144309.GB3412@bricha3-MOBL3> <20141128145920.GC3412@bricha3-MOBL3> Date: Fri, 28 Nov 2014 16:41:07 +0100 Message-ID: From: David Marchand To: Bruce Richardson Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] scripts: fix symbol overriding in configuration files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 15:41:08 -0000 On Fri, Nov 28, 2014 at 3:59 PM, Bruce Richardson < bruce.richardson@intel.com> wrote: > Yes, it's ugly, but it's probably more resilient. I'm looking forward to > getting > an option C. > Option C and D are ugly as well (using some bashism like $' ' or using an intermediate variable with a newline in it). Our "posix" guy told me that he prefers the initial version of the patch. I will send a patch with this. Thomas ? -- David Marchand