From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/test: fix log check when default level is high
Date: Tue, 17 May 2016 08:54:35 +0200 [thread overview]
Message-ID: <CALwxeUu_ina5L=cN0=4eO0PzV4zF7YC24kHKoE4ycm=UJ-zTKQ@mail.gmail.com> (raw)
In-Reply-To: <1462368890-17917-1-git-send-email-thomas.monjalon@6wind.com>
Hello Thomas,
On Wed, May 4, 2016 at 3:34 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> The log unit test was checking display of low priority messages.
> It was not working if RTE_LOG_LEVEL is not RTE_LOG_DEBUG.
> It is even easier to see since the default level is INFO (9b9d7ca).
>
> Now the test use ERR and CRIT levels which should be always enabled
> while not trigerring syslog output on the console.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> app/test/autotest_test_funcs.py | 20 ++++++++------------
> app/test/test_logs.c | 20 +++++++++-----------
> 2 files changed, 17 insertions(+), 23 deletions(-)
>
> diff --git a/app/test/autotest_test_funcs.py b/app/test/autotest_test_funcs.py
> index 0f012f6..f04909d 100644
> --- a/app/test/autotest_test_funcs.py
> +++ b/app/test/autotest_test_funcs.py
> @@ -145,18 +145,14 @@ def logs_autotest(child, test_name):
> child.sendline(test_name)
>
> log_list = [
> - "TESTAPP1: this is a debug level message",
> - "TESTAPP1: this is a info level message",
> - "TESTAPP1: this is a warning level message",
> - "TESTAPP2: this is a info level message",
> - "TESTAPP2: this is a warning level message",
> - "TESTAPP1: this is a debug level message",
> - "TESTAPP1: this is a debug level message",
> - "TESTAPP1: this is a info level message",
> - "TESTAPP1: this is a warning level message",
> - "TESTAPP2: this is a info level message",
> - "TESTAPP2: this is a warning level message",
> - "TESTAPP1: this is a debug level message",
> + "TESTAPP1: error message",
> + "TESTAPP1: critical message",
> + "TESTAPP2: critical message",
> + "TESTAPP1: error message",
> + "TESTAPP1: error message",
> + "TESTAPP1: critical message",
> + "TESTAPP2: critical message",
> + "TESTAPP1: error message",
Since this list is tighly coupled to test_logs.c, a little comment on
why the messages are declared twice in this list would help.
> ]
>
> for log_msg in log_list:
> diff --git a/app/test/test_logs.c b/app/test/test_logs.c
> index 18a3b6a..861cdff 100644
> --- a/app/test/test_logs.c
> +++ b/app/test/test_logs.c
> @@ -66,24 +66,22 @@ test_logs(void)
> rte_set_log_type(RTE_LOGTYPE_TESTAPP2, 1);
>
> /* log in debug level */
> - rte_set_log_level(RTE_LOG_DEBUG);
> - RTE_LOG(DEBUG, TESTAPP1, "this is a debug level message\n");
> - RTE_LOG(INFO, TESTAPP1, "this is a info level message\n");
> - RTE_LOG(WARNING, TESTAPP1, "this is a warning level message\n");
> + rte_set_log_level(RTE_LOG_ERR);
> + RTE_LOG(ERR, TESTAPP1, "error message\n");
> + RTE_LOG(CRIT, TESTAPP1, "critical message\n");
Comment is wrong, should be about error level.
>
> /* log in info level */
> - rte_set_log_level(RTE_LOG_INFO);
> - RTE_LOG(DEBUG, TESTAPP2, "debug level message (not displayed)\n");
> - RTE_LOG(INFO, TESTAPP2, "this is a info level message\n");
> - RTE_LOG(WARNING, TESTAPP2, "this is a warning level message\n");
> + rte_set_log_level(RTE_LOG_CRIT);
> + RTE_LOG(ERR, TESTAPP2, "error message (not displayed)\n");
> + RTE_LOG(CRIT, TESTAPP2, "critical message\n");
Idem.
>
> /* disable one log type */
> rte_set_log_type(RTE_LOGTYPE_TESTAPP2, 0);
>
> /* log in debug level */
> - rte_set_log_level(RTE_LOG_DEBUG);
> - RTE_LOG(DEBUG, TESTAPP1, "this is a debug level message\n");
> - RTE_LOG(DEBUG, TESTAPP2, "debug level message (not displayed)\n");
> + rte_set_log_level(RTE_LOG_ERR);
> + RTE_LOG(ERR, TESTAPP1, "error message\n");
> + RTE_LOG(ERR, TESTAPP2, "error message (not displayed)\n");
Idem.
--
David Marchand
next prev parent reply other threads:[~2016-05-17 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 13:34 Thomas Monjalon
2016-05-17 6:54 ` David Marchand [this message]
2016-05-17 7:05 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-05-24 15:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUu_ina5L=cN0=4eO0PzV4zF7YC24kHKoE4ycm=UJ-zTKQ@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).