From: David Marchand <david.marchand@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>,
michalx.k.jastrzebski@intel.com
Subject: Re: [dpdk-dev] [PATCH] eal: Fix resource leak of pci_uio_map_secondary()
Date: Wed, 15 Jun 2016 16:45:25 +0200 [thread overview]
Message-ID: <CALwxeUubgXDxYZsTCdAM789UWYosGJOx2V7cuZzbQtvgPCNoJw@mail.gmail.com> (raw)
In-Reply-To: <1465961172-28253-1-git-send-email-mukawa@igel.co.jp>
Hello Tetsuya,
On Wed, Jun 15, 2016 at 5:26 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
> If pci_map_resource() succeeds but mapped address is different from an
> address primary process mapped, this should be error.
> Then the address secondary process mapped should be freed.
>
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
The title should not contain the function name.
> ---
> lib/librte_eal/common/eal_common_pci_uio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_pci_uio.c b/lib/librte_eal/common/eal_common_pci_uio.c
> index f062e81..e718643 100644
> --- a/lib/librte_eal/common/eal_common_pci_uio.c
> +++ b/lib/librte_eal/common/eal_common_pci_uio.c
> @@ -85,6 +85,9 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
> "Cannot mmap device resource file %s to address: %p\n",
> uio_res->maps[i].path,
> uio_res->maps[i].addr);
> + if (mapaddr != MAP_FAILED)
> + pci_unmap_resource(mapaddr,
> + (size_t)uio_res->maps[i].size);
> return -1;
> }
> }
What of the previous mappings that might have succeeded earlier in this loop ?
--
David Marchand
next prev parent reply other threads:[~2016-06-15 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 3:26 [dpdk-dev] [PATCH] eal: Fix wrong error checking of rte_eal_parse_devargs_str() Tetsuya Mukawa
2016-06-15 14:48 ` David Marchand
2016-06-16 2:03 ` Tetsuya Mukawa
2016-06-16 2:33 ` [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments Tetsuya Mukawa
2016-06-15 3:26 ` [dpdk-dev] [PATCH] eal: Fix resource leak of pci_uio_map_secondary() Tetsuya Mukawa
2016-06-15 14:45 ` David Marchand [this message]
2016-06-16 2:03 ` Tetsuya Mukawa
2016-06-16 2:33 ` [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices Tetsuya Mukawa
2016-06-17 12:28 ` David Marchand
2016-06-20 2:19 ` Tetsuya Mukawa
2016-06-20 8:50 ` Thomas Monjalon
2016-06-15 3:27 ` [dpdk-dev] [PATCH] eal: Fix wrong resource release of pci_uio_unmap() Tetsuya Mukawa
2016-06-15 15:01 ` David Marchand
2016-06-16 2:33 ` [dpdk-dev] [PATCH v2] eal: Fix wrong resource release while unmapping pci devices Tetsuya Mukawa
2016-06-17 12:12 ` David Marchand
2016-06-20 8:50 ` Thomas Monjalon
2016-06-17 12:10 ` [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments David Marchand
2016-06-20 8:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUubgXDxYZsTCdAM789UWYosGJOx2V7cuZzbQtvgPCNoJw@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=mukawa@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).