From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 19D3C7E18 for ; Mon, 29 Sep 2014 16:33:58 +0200 (CEST) Received: by mail-wi0-f170.google.com with SMTP id n3so2899657wiv.5 for ; Mon, 29 Sep 2014 07:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=rnjEqTkLGaXMTx7Gj7x2ZNwEk0d9ypw2WtpzC70ipV8=; b=Kz9tJQ8jErfeJI2MyvWU8iohj1Ch/2A7zCsmKZypCSjuMM+e+HN5Rf5SpcD9FLZ7iM IEEITWovgbeC2Vv+YjI0poaAmfPza+a+jzgeyJh60ozotAmv+atAYKWJORjrMQ/csUSQ 2TpbP+bZHU5C4/S7OY5KyD4tCNKNsL1pWnUAzLbQRbEylz/618OhsT6Fuf7vjFTuNKoH Cn4b5yuRKv6s0kt7ie9fB7W6sJ3Bk5VJ+5FHquHK9stXEQ3zq1v4bBf61/obEKr3Yefp z2kccyFqtRNNu8Xw8YuTg/DclJUBp7wIDx4rn2Ji1JegVYtSUUNdqBsY/fcM+2250gx9 8AJA== X-Gm-Message-State: ALoCoQnuRhNMQTyUj17YnchBCOUu91OvgFyOmbkdgtiNt3HbFH62i56kIuNZrK00GvNo0/P1teVp MIME-Version: 1.0 X-Received: by 10.180.102.68 with SMTP id fm4mr47137609wib.27.1412001634262; Mon, 29 Sep 2014 07:40:34 -0700 (PDT) Received: by 10.194.47.133 with HTTP; Mon, 29 Sep 2014 07:40:34 -0700 (PDT) In-Reply-To: References: <1411741159-6671-1-git-send-email-pablo.de.lara.guarch@intel.com> Date: Mon, 29 Sep 2014 16:40:34 +0200 Message-ID: From: David Marchand To: "De Lara Guarch, Pablo" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 14:33:58 -0000 Hello Pablo, On Mon, Sep 29, 2014 at 4:02 PM, De Lara Guarch, Pablo < pablo.de.lara.guarch@intel.com> wrote: > Hi David, > > > - All I can see in this patchset is stuff that should remain in the PMD > (since > > this is really specific to them). > > > > - Anyway, if you want to let application get this information, why the > new API > > ? > > From my point of view, this should go in rte_eth_dev_info_get(). > > Thanks for the comments. Main changes are in the PMDs, and I only added > two functions in rte_ethdev.c, which basically calls the functions in the > PMDs. > Anyway, so you suggest to modify the rte_eth_dev_info structure, so it > also contains these two structures populated with the default values? > - Yep, that would be the idea. This way applications can reuse these structures "as is" or change some values before calling rx / tx _queue_setup. - By the way, I noticed that rte_eth_dev_info_get() is only resetting part of the dev_info structure given by the user. We might want to reset the dev_info structure to 0 before filling it ? >>From my point of view, rte_eth_dev_info_get() is not in the datapath. I would prefer it to be safe. -- David Marchand