* [dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains
@ 2016-10-11 13:49 Kamil Rytarowski
2016-10-11 16:52 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Kamil Rytarowski @ 2016-10-11 13:49 UTC (permalink / raw)
To: dev
Cc: maciej.czekaj, zyta.szpak, slawomir.rosek, rad, jerin.jacob,
ferruh.yigit, Kamil Rytarowski, Kamil Rytarowski
It's possible to have the same numbers for bus, device id and function,
therefore we need to differentiate on domain.
This enables DPDK with multiple VFs on ThunderX 2-socket hardware.
Signed-off-by: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
Signed-off-by: Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>
Signed-off-by: Zyta Szpak <zyta.szpak@semihalf.com>
Signed-off-by: Slawomir Rosek <slawomir.rosek@semihalf.com>
Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 382c959..01d5fb0 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -225,7 +225,7 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size,
{
int ret;
- ret = snprintf(name, size, "%d:%d.%d",
+ ret = snprintf(name, size, "%d:%d:%d.%d", pci_dev->addr.domain,
pci_dev->addr.bus, pci_dev->addr.devid,
pci_dev->addr.function);
if (ret < 0)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains
2016-10-11 13:49 [dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains Kamil Rytarowski
@ 2016-10-11 16:52 ` David Marchand
2016-10-12 17:07 ` Kamil Rytarowski
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2016-10-11 16:52 UTC (permalink / raw)
To: Kamil Rytarowski
Cc: dev, maciej.czekaj, zyta.szpak, slawomir.rosek, rad, Jerin Jacob,
Ferruh Yigit, Kamil Rytarowski
On Tue, Oct 11, 2016 at 3:49 PM, Kamil Rytarowski
<krytarowski@caviumnetworks.com> wrote:
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 382c959..01d5fb0 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -225,7 +225,7 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size,
> {
> int ret;
>
> - ret = snprintf(name, size, "%d:%d.%d",
> + ret = snprintf(name, size, "%d:%d:%d.%d", pci_dev->addr.domain,
> pci_dev->addr.bus, pci_dev->addr.devid,
> pci_dev->addr.function);
> if (ret < 0)
This patch is obsolete since this part has been moved to eal.
Can you test with current master branch if there is still an issue ?
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains
2016-10-11 16:52 ` David Marchand
@ 2016-10-12 17:07 ` Kamil Rytarowski
0 siblings, 0 replies; 3+ messages in thread
From: Kamil Rytarowski @ 2016-10-12 17:07 UTC (permalink / raw)
To: David Marchand
Cc: dev, maciej.czekaj, zyta.szpak, slawomir.rosek, rad, Jerin Jacob,
Ferruh Yigit, Kamil Rytarowski
W dniu 11.10.2016 o 18:52, David Marchand pisze:
> On Tue, Oct 11, 2016 at 3:49 PM, Kamil Rytarowski
> <krytarowski@caviumnetworks.com> wrote:
>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
>> index 382c959..01d5fb0 100644
>> --- a/lib/librte_ether/rte_ethdev.c
>> +++ b/lib/librte_ether/rte_ethdev.c
>> @@ -225,7 +225,7 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size,
>> {
>> int ret;
>>
>> - ret = snprintf(name, size, "%d:%d.%d",
>> + ret = snprintf(name, size, "%d:%d:%d.%d", pci_dev->addr.domain,
>> pci_dev->addr.bus, pci_dev->addr.devid,
>> pci_dev->addr.function);
>> if (ret < 0)
> This patch is obsolete since this part has been moved to eal.
>
> Can you test with current master branch if there is still an issue ?
> Thanks.
>
>
I've tested DPDK master without this PCI domain patch and everything
seems to work.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-12 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-11 13:49 [dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains Kamil Rytarowski
2016-10-11 16:52 ` David Marchand
2016-10-12 17:07 ` Kamil Rytarowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).