From: David Marchand <david.marchand@6wind.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 16/17] e1000: add a message when forcing scatter mode
Date: Tue, 2 Sep 2014 21:20:26 +0200 [thread overview]
Message-ID: <CALwxeUuvN-qnHwFsrxnKwknV-o1ekZCj_1=ZWzGcnM7bd0-WaQ@mail.gmail.com> (raw)
In-Reply-To: <1409567080-27083-17-git-send-email-david.marchand@6wind.com>
Self nack, forgot to remove the \n ...
--
David Marchand
On Mon, Sep 1, 2014 at 12:24 PM, David Marchand <david.marchand@6wind.com>
wrote:
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> lib/librte_pmd_e1000/em_rxtx.c | 4 ++++
> lib/librte_pmd_e1000/igb_rxtx.c | 14 ++++++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/lib/librte_pmd_e1000/em_rxtx.c
> b/lib/librte_pmd_e1000/em_rxtx.c
> index 83ecb33..a6cea32 100644
> --- a/lib/librte_pmd_e1000/em_rxtx.c
> +++ b/lib/librte_pmd_e1000/em_rxtx.c
> @@ -1707,6 +1707,8 @@ eth_em_rx_init(struct rte_eth_dev *dev)
> */
> if (dev->data->dev_conf.rxmode.jumbo_frame ||
> rctl_bsize < ETHER_MAX_LEN) {
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG, "forcing scatter
> mode\n");
> dev->rx_pkt_burst =
> (eth_rx_burst_t)eth_em_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> @@ -1714,6 +1716,8 @@ eth_em_rx_init(struct rte_eth_dev *dev)
> }
>
> if (dev->data->dev_conf.rxmode.enable_scatter) {
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG, "forcing scatter mode\n");
> dev->rx_pkt_burst = eth_em_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c
> b/lib/librte_pmd_e1000/igb_rxtx.c
> index 5ca06c9..1d8f74a 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -1978,6 +1978,9 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
> /* It adds dual VLAN length for supporting dual
> VLAN */
> if ((dev->data->dev_conf.rxmode.max_rx_pkt_len +
> 2 * VLAN_TAG_SIZE) >
> buf_size){
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG,
> + "forcing scatter
> mode\n");
> dev->rx_pkt_burst =
> eth_igb_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> @@ -1987,6 +1990,8 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
> */
> if ((rctl_bsize == 0) || (rctl_bsize > buf_size))
> rctl_bsize = buf_size;
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG, "forcing scatter
> mode\n");
> dev->rx_pkt_burst = eth_igb_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> @@ -2008,6 +2013,8 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
> }
>
> if (dev->data->dev_conf.rxmode.enable_scatter) {
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG, "forcing scatter mode\n");
> dev->rx_pkt_burst = eth_igb_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> @@ -2242,6 +2249,9 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
> /* It adds dual VLAN length for supporting dual
> VLAN */
> if ((dev->data->dev_conf.rxmode.max_rx_pkt_len +
> 2 * VLAN_TAG_SIZE) >
> buf_size){
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG,
> + "forcing scatter
> mode\n");
> dev->rx_pkt_burst =
> eth_igb_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> @@ -2251,6 +2261,8 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
> */
> if ((rctl_bsize == 0) || (rctl_bsize > buf_size))
> rctl_bsize = buf_size;
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG, "forcing scatter
> mode\n");
> dev->rx_pkt_burst = eth_igb_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> @@ -2282,6 +2294,8 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
> }
>
> if (dev->data->dev_conf.rxmode.enable_scatter) {
> + if (!dev->data->scattered_rx)
> + PMD_INIT_LOG(DEBUG, "forcing scatter mode\n");
> dev->rx_pkt_burst = eth_igb_recv_scattered_pkts;
> dev->data->scattered_rx = 1;
> }
> --
> 1.7.10.4
>
>
next prev parent reply other threads:[~2014-09-02 19:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 10:24 [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro David Marchand
2014-09-02 13:43 ` Jay Rolette
2014-09-02 14:16 ` David Marchand
2014-09-02 14:21 ` Thomas Monjalon
2014-09-02 17:57 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 02/17] ixgbe/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 03/17] ixgbe: clean log messages David Marchand
2014-09-02 15:19 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 04/17] ixgbe: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 05/17] ixgbe: add a message when forcing scatter mode David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 06/17] ixgbe: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 07/17] i40e: use the right debug macro David Marchand
2014-09-02 18:25 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 08/17] i40e/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 09/17] i40e: clean log messages David Marchand
2014-09-02 18:20 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 10/17] i40e: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 11/17] i40e: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 12/17] e1000: use the right debug macro David Marchand
2014-09-02 18:29 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 13/17] e1000/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 14/17] e1000: clean log messages David Marchand
2014-09-02 19:05 ` Jay Rolette
2014-09-02 19:19 ` David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 15/17] e1000: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 16/17] e1000: add a message when forcing scatter mode David Marchand
2014-09-02 19:20 ` David Marchand [this message]
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 17/17] eal: set log level from command line David Marchand
2014-09-12 12:32 ` [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUuvN-qnHwFsrxnKwknV-o1ekZCj_1=ZWzGcnM7bd0-WaQ@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).