From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id 118245947 for ; Tue, 2 Sep 2014 21:15:53 +0200 (CEST) Received: by mail-ob0-f173.google.com with SMTP id uy5so5260576obc.4 for ; Tue, 02 Sep 2014 12:20:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=MP1hyBWkKrKu50uLCTHMzXM7jiSNL+ER6D/kgKDaQno=; b=H6DF47H54GTC4i2e9fJVUcb0NaS1Gjc3JpNhH+8dQ/CkMlUL7J6/1PpDGgnUEFbjij cfRjRvUNRhxuXtQzqRlf0cMgI0cjVc+WB/QSm9m+e7Js/jy/bevPnoK53VqAHGE7t/kX 48wE5n7flaFHWVh7OHsfMcAwAm6kbz3uX1RDSsDe+3EbqG4uERJBmpRtPBKv0svxKB2g YPgjMNGbU1NZ1zrYvnTbPyM0gLlCx13tYoEt15veraVre9nyTPiYYkxEnVie9i9NmZmF MDJWigv7K+ax8kJGhY80IMIsOE0+OE4eJzh9Ia97h66/BlTBj86yBd9jZS99LPLDfUrd gKxw== X-Gm-Message-State: ALoCoQnduPIeJ28brjrLx/iZXWxnKGcNelb1CNmyGNMrsdERXXYruHtZTz4Ye2FcQ6m0PQVFUBvX MIME-Version: 1.0 X-Received: by 10.60.96.129 with SMTP id ds1mr3630583oeb.43.1409685626316; Tue, 02 Sep 2014 12:20:26 -0700 (PDT) Received: by 10.202.73.74 with HTTP; Tue, 2 Sep 2014 12:20:26 -0700 (PDT) In-Reply-To: <1409567080-27083-17-git-send-email-david.marchand@6wind.com> References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com> <1409567080-27083-17-git-send-email-david.marchand@6wind.com> Date: Tue, 2 Sep 2014 21:20:26 +0200 Message-ID: From: David Marchand To: "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 16/17] e1000: add a message when forcing scatter mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 19:15:54 -0000 Self nack, forgot to remove the \n ... -- David Marchand On Mon, Sep 1, 2014 at 12:24 PM, David Marchand wrote: > Signed-off-by: David Marchand > --- > lib/librte_pmd_e1000/em_rxtx.c | 4 ++++ > lib/librte_pmd_e1000/igb_rxtx.c | 14 ++++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/lib/librte_pmd_e1000/em_rxtx.c > b/lib/librte_pmd_e1000/em_rxtx.c > index 83ecb33..a6cea32 100644 > --- a/lib/librte_pmd_e1000/em_rxtx.c > +++ b/lib/librte_pmd_e1000/em_rxtx.c > @@ -1707,6 +1707,8 @@ eth_em_rx_init(struct rte_eth_dev *dev) > */ > if (dev->data->dev_conf.rxmode.jumbo_frame || > rctl_bsize < ETHER_MAX_LEN) { > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, "forcing scatter > mode\n"); > dev->rx_pkt_burst = > (eth_rx_burst_t)eth_em_recv_scattered_pkts; > dev->data->scattered_rx = 1; > @@ -1714,6 +1716,8 @@ eth_em_rx_init(struct rte_eth_dev *dev) > } > > if (dev->data->dev_conf.rxmode.enable_scatter) { > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, "forcing scatter mode\n"); > dev->rx_pkt_burst = eth_em_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > diff --git a/lib/librte_pmd_e1000/igb_rxtx.c > b/lib/librte_pmd_e1000/igb_rxtx.c > index 5ca06c9..1d8f74a 100644 > --- a/lib/librte_pmd_e1000/igb_rxtx.c > +++ b/lib/librte_pmd_e1000/igb_rxtx.c > @@ -1978,6 +1978,9 @@ eth_igb_rx_init(struct rte_eth_dev *dev) > /* It adds dual VLAN length for supporting dual > VLAN */ > if ((dev->data->dev_conf.rxmode.max_rx_pkt_len + > 2 * VLAN_TAG_SIZE) > > buf_size){ > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, > + "forcing scatter > mode\n"); > dev->rx_pkt_burst = > eth_igb_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > @@ -1987,6 +1990,8 @@ eth_igb_rx_init(struct rte_eth_dev *dev) > */ > if ((rctl_bsize == 0) || (rctl_bsize > buf_size)) > rctl_bsize = buf_size; > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, "forcing scatter > mode\n"); > dev->rx_pkt_burst = eth_igb_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > @@ -2008,6 +2013,8 @@ eth_igb_rx_init(struct rte_eth_dev *dev) > } > > if (dev->data->dev_conf.rxmode.enable_scatter) { > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, "forcing scatter mode\n"); > dev->rx_pkt_burst = eth_igb_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > @@ -2242,6 +2249,9 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev) > /* It adds dual VLAN length for supporting dual > VLAN */ > if ((dev->data->dev_conf.rxmode.max_rx_pkt_len + > 2 * VLAN_TAG_SIZE) > > buf_size){ > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, > + "forcing scatter > mode\n"); > dev->rx_pkt_burst = > eth_igb_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > @@ -2251,6 +2261,8 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev) > */ > if ((rctl_bsize == 0) || (rctl_bsize > buf_size)) > rctl_bsize = buf_size; > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, "forcing scatter > mode\n"); > dev->rx_pkt_burst = eth_igb_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > @@ -2282,6 +2294,8 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev) > } > > if (dev->data->dev_conf.rxmode.enable_scatter) { > + if (!dev->data->scattered_rx) > + PMD_INIT_LOG(DEBUG, "forcing scatter mode\n"); > dev->rx_pkt_burst = eth_igb_recv_scattered_pkts; > dev->data->scattered_rx = 1; > } > -- > 1.7.10.4 > >