From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id 28BB49AB3 for ; Tue, 24 Feb 2015 13:35:05 +0100 (CET) Received: by mail-ob0-f182.google.com with SMTP id nt9so42112619obb.13 for ; Tue, 24 Feb 2015 04:35:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=undpbX2utrI+QJ8X1Sy7SEHo2McMqx+ELCrTRHOH0g4=; b=OoX1bBDc70csk+36Pi41F6Xpvj0Joo5/HDtLpjIwy2izGiQSjAry6UauSyUbnFnJWd YF0bzoTUtikbeANxdApZ/Ytt7VpPaV0AZpv5ktJ4mGB8mWYlR+M+PpsBw+m9Kc0p5Uol 4DGXITlzWL1ENqqbIbA/NccMwv9j2AU+gJub8QhtAfDe/ux+QjHXxVvoZ6F7oWgO5i3T aU7w2ecLOMtCBgU3xSCImNdzw8iB3eRKdU6pcEhltfNIHJDFAhkSoEukdyIe3t9si/iN qmPt7trwESokjEfb7KhjS+oB6OSNlwZ/V2wDg/wLcxZ58Tg11fNAxSasf8pNAG/3ect6 yh/Q== X-Gm-Message-State: ALoCoQk6/VwNmQdmiaOJaA4LFzL0AS2m3h5dVA8iSmevISaGtWgicssCm00wTvssC+8RpZhatsbe MIME-Version: 1.0 X-Received: by 10.60.97.35 with SMTP id dx3mr10923850oeb.6.1424781304492; Tue, 24 Feb 2015 04:35:04 -0800 (PST) Received: by 10.76.133.162 with HTTP; Tue, 24 Feb 2015 04:35:04 -0800 (PST) In-Reply-To: <20150224113247.GE8416@bricha3-MOBL3> References: <1424703444-30761-1-git-send-email-bruce.richardson@intel.com> <1424710955-10896-1-git-send-email-bruce.richardson@intel.com> <20150224105357.GD8416@bricha3-MOBL3> <20150224113247.GE8416@bricha3-MOBL3> Date: Tue, 24 Feb 2015 13:35:04 +0100 Message-ID: From: David Marchand To: Bruce Richardson Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 12:35:05 -0000 On Tue, Feb 24, 2015 at 12:32 PM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Tue, Feb 24, 2015 at 12:23:15PM +0100, David Marchand wrote: > > Hello Bruce, > > > > On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < > > bruce.richardson@intel.com> wrote: > > > > > On Mon, Feb 23, 2015 at 05:02:33PM +0000, Bruce Richardson wrote: > > > > This patch does some cleanup of the uio mapping code to > > > > a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed > > > > by others. > > > > b) eliminate redundant code and reduce scans of /sys > > > > > > > > > > > > Bruce Richardson (2): > > > > eal: mmap uio resources using resourceX files > > > > eal: populate uio_maps from pci mem_resources array > > > > > > > > lib/librte_eal/common/include/rte_pci.h | 2 +- > > > > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > > > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 173 > > > +++++++++++------------------ > > > > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > > > > 4 files changed, 66 insertions(+), 111 deletions(-) > > > > > > > > -- > > > > 2.1.0 > > > > > > > Given your previous suggestions on the uio_pic_generic code, I'd > appreciate > > > any feedback you could provide on this patchset. > > > > > > Well, I only have one pending question on the use of resourceX files > > instead of /dev/uioX. > > You rely on sysfs mmap code for pci resources. > > Is this really equivalent to uio mmap operations ? > > uio_pci_generic provides no mappings via /dev/uioX, so the may to mmap the > bars using uio_pci_generic is via the sysfs. [1] > > > If you can ensure me this won't break igb_uio setups, then these patches > > are ok for me. > > Since igb_uio is based on the same uio_pci_generic framework, what works > for > uio_pci_generic should work for igb_uio also - and testing indicates that > this > works. Danny could perhaps provide better insights than I can into any > guarantees > as to not breaking things, but I've tested this on a couple of platforms > with > 1G and 10G NICs using both igb_uio and uio_pci_generic, both individually > and > in combination. I've also verified multiprocess support and done a quick > sanity > test with 32-bit. Everything seems ok in testing thus far. > Ok, noted. I am looking at your v3. -- David Marchand