From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by dpdk.org (Postfix) with ESMTP id 80A755697 for ; Wed, 14 Oct 2015 13:45:10 +0200 (CEST) Received: by oixx6 with SMTP id x6so10171253oix.2 for ; Wed, 14 Oct 2015 04:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=q2f+V+0isBvT/J73FY9HQJZEP7F+9CUxNh0nRnerX3E=; b=g81dIKZuFQUxyiiN1at9MWYEjjcsSoh3ZHjDhHPlaFLVxVRela6nlWqqk4ktfnVL+9 So87bYqPkGEm7bWYuV0TcDq/iLQmIoRynIyCSYoShihCK/Qpn1Y1GKA0uph6uVvWE0NJ 7BrD1wVsxMXWjJS00Po5pokBTG1zRikBXtoFh7FraJtiV8UnPMo6RVXtvS9r7cbq275z iVQ3h4Ca85QPT5R5Zb/yJ7wB4UibLoiGbOfQk+I8l2iwEbIAqFoELR7QVFckRa1GWex5 juwbZxacNxg+63Y2Tp5ctGgTo/4zXu6eYB5FjMm0NfLaDniOHmY7JVc0gsQPVYNr8Z6N sdNw== X-Gm-Message-State: ALoCoQkQP5gKeiJegIYpDSQ6cQ/nPx+G0oJQojeGTD85Fjgxx0VcOB/nKDGaLHexWWK7MdqqrR1t MIME-Version: 1.0 X-Received: by 10.202.92.134 with SMTP id q128mr1284860oib.90.1444823109904; Wed, 14 Oct 2015 04:45:09 -0700 (PDT) Received: by 10.76.131.166 with HTTP; Wed, 14 Oct 2015 04:45:09 -0700 (PDT) In-Reply-To: References: Date: Wed, 14 Oct 2015 13:45:09 +0200 Message-ID: From: David Marchand To: Panu Matilainen Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: default to one memory channel if not specified X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 11:45:10 -0000 Hello Panu, On Wed, Oct 14, 2015 at 12:22 PM, Panu Matilainen wrote: > Obtaining the correct value, especially from a running system, can > be anything from difficult to plain impossible. Since the value is > merely an optimization and does not affect functionality otherwise, > its pointless to force such a guess on users initially, such things > belong to performance tuning phase. > > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/common/eal_common_options.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 1f459ac..28f10a2 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -104,7 +104,7 @@ eal_reset_internal_config(struct internal_config > *internal_cfg) > > internal_cfg->memory = 0; > internal_cfg->force_nrank = 0; > - internal_cfg->force_nchannel = 0; > + internal_cfg->force_nchannel = 1; > Well, not too sure about this default value. - mempool code is already checking for the 0 value. - API already tells for rte_memory_get_nchannel() : * @return * The number of memory channels on the system. The value is 0 if unknown * or not the same on all devices. So, I would let it 0. -- David Marchand