From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f172.google.com (mail-ob0-f172.google.com
 [209.85.214.172]) by dpdk.org (Postfix) with ESMTP id 5FD9A5A8E
 for <dev@dpdk.org>; Mon, 30 Mar 2015 22:50:37 +0200 (CEST)
Received: by obcjt1 with SMTP id jt1so139408260obc.2
 for <dev@dpdk.org>; Mon, 30 Mar 2015 13:50:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=EdcF0eRdjONJCCfLh/tplpwFom75uSZXlHvmdWYPy/0=;
 b=VOB+Hq3Zh4KxPxCs9dVP3K+f9n/UTQpNgw9bhYtgL9k4WQTkVKOqRC/Q6KFRuRtGo1
 oVF/TS3vhOCN5IqWVDikherNAw11qAkKJ5rVE7thiOL/99vdyT7+ymsS667K2GTyl97J
 KbLSiVK9MinD9H85gkQmju6NAOyRioiv+y+pi9Cq9YniXBUlQCiij2V2R4tE5A4XzLAs
 UMusRXm5Pcdjfl3Ja8GVr831fb+IbqzztWj3qqjKgbuq35XswMZXizNLzBFY8nV0PApj
 KBSQvBfUMgVQDbq3LuzwTtTsZASUsmC9zFoKy1R1vR7Ponl4MOuiiruBfRbGKfUSNAAO
 NxPQ==
X-Gm-Message-State: ALoCoQlZsNaxmA91krnILtTB1HbqLXwr3ycC/0E+L/7TBQnoDKtnH3gIqGVYkBHXphhgogNFoIx+
MIME-Version: 1.0
X-Received: by 10.60.42.211 with SMTP id q19mr28836287oel.58.1427748636822;
 Mon, 30 Mar 2015 13:50:36 -0700 (PDT)
Received: by 10.76.23.4 with HTTP; Mon, 30 Mar 2015 13:50:36 -0700 (PDT)
In-Reply-To: <1427709404-28921-2-git-send-email-maciejx.t.gajdzica@intel.com>
References: <1427709404-28921-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1427709404-28921-2-git-send-email-maciejx.t.gajdzica@intel.com>
Date: Mon, 30 Mar 2015 22:50:36 +0200
Message-ID: <CALwxeUuzbiJsNZsUsfB1+vQpSkGmhdukUU_o6LMGX1hV8BwHeg@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] port: added WRITER_APPROACH == 1
 implementation to ring port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2015 20:50:37 -0000

On Mon, Mar 30, 2015 at 11:56 AM, Maciej Gajdzica <
maciejx.t.gajdzica@intel.com> wrote:

> Added better optimized implementation of tx_bulk for ring writer port
> based on
> similar solution in ethdev_writer port. New implementation sends burst
> without
> copying data to internal buffer if it is possible.
>

Well, if this is such a better implementation, then remove the old one.
We don't want dead code.


>
> ---
>  lib/librte_port/rte_port_ring.c |   59
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
>
> diff --git a/lib/librte_port/rte_port_ring.c
> b/lib/librte_port/rte_port_ring.c
> index fa3d77b..ba2eeb3 100644
> --- a/lib/librte_port/rte_port_ring.c
> +++ b/lib/librte_port/rte_port_ring.c
> @@ -96,11 +96,14 @@ rte_port_ring_reader_free(void *port)
>  /*
>   * Port RING Writer
>   */
> +#define RTE_PORT_RING_WRITER_APPROACH                  1
> +
>

Seriously, can't we just drop this ?

Having build options everywhere is a pain.
Having this kind of stuff is worse ...

I can see other places that do the same, are these parts maintained ?


-- 
David Marchand