From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id 337E19594 for ; Wed, 27 Jan 2016 11:24:55 +0100 (CET) Received: by mail-ob0-f169.google.com with SMTP id zv1so3357650obb.2 for ; Wed, 27 Jan 2016 02:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=QqlwP6qNNgQ/RvBC9te7vq93cnRzTTVnlGO/+9O9rDU=; b=V9qreINhaTp+gLXUwiNDUKm+R3nbum4XeKfqa78BfUHZ+rC7QBaveZPb21V3lKhO/G ENRcA1Z0xo2bqJsjzpPB8OcKsAfn18UiRZ4ZOZSXwWxvx3Uba/kTdLprhB8tn8mwH0Ja SS5c3+SMjZieT+TCRfAxsLi4wVb7Nd8FkokXhCWkoSPmP6JEbrrHlTTvVKvK/izSPjci +oAX2znKPA3+uAEbHDT8JMUmuLK40z6w59qkOoywwjtDBnmJt6YdvC/zYN9+VR+gpflh sunxRtkBGeX/d0p50n4cttsvOKvGKgZ/P4t8EEE0Eyz4qoZ2WBucGue5bqYTGGdMQd4I FgqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=QqlwP6qNNgQ/RvBC9te7vq93cnRzTTVnlGO/+9O9rDU=; b=cl47vzbR0Kpab/Y94983x+0euaqMhLr9r6EellZmV8oDGlbYKODKeS2SSSW4f1bKad PIoadEqbMhWt9hlCcq8UlCaM+m3dWCAzTcvyUsqgGYUyBNPxgklp/de3keb2oIdFa7Vb ol088p9ncZTIooaoRqMgyXurf3OFZlKWyDnoKPB+2zDSFvV/prbBe7LdF9M0nfrICpo2 Qamew/1Q3F+/gKYfuwn822wYSJmT3Cmy54e81wad8eVOFLKJdKkoeOgqlgpdw9IAaDUO rtIAkJVvhvK6Sz2izx8QbXjfLICrXkw7e1T4+gCAkRHpHnnSvGSPDK4C571G5/whJWH/ 2Z+w== X-Gm-Message-State: AG10YOQVsY4zeUrXPVMDGWYZk8A8FhSNd/OmOWPOWgF3v4AG/15DQsCM47tOUZZ8usGLqWjK7SbF81D4xRA6cFM5 X-Received: by 10.182.60.170 with SMTP id i10mr21105180obr.62.1453890294575; Wed, 27 Jan 2016 02:24:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Wed, 27 Jan 2016 02:24:34 -0800 (PST) In-Reply-To: <2170759.xLIetSvQoP@xps13> References: <1450728967-9686-1-git-send-email-anatoly.burakov@intel.com> <1584319.QMRQbZMs1h@xps13> <2170759.xLIetSvQoP@xps13> From: David Marchand Date: Wed, 27 Jan 2016 11:24:34 +0100 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 10:24:55 -0000 On Wed, Jan 27, 2016 at 11:12 AM, Thomas Monjalon wrote: > 2016-01-27 10:08, Burakov, Anatoly: >> > Why a new file for these functions? >> >> Well, my thought was to make future extensions easier by way of avoiding mixing irrelevant and/or general code with driver-specific code. I can change it back if that's not OK. > > No strong opinion here. > David? Hum, no strong opinion either, but I don't think we really need to split this file for this much code. Besides, if we keep all code in eal_pci_vfio.c, there is no need to expose those structures through eal_pci_init.h. -- David Marchand