From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com
 [209.85.218.47]) by dpdk.org (Postfix) with ESMTP id C23F21396
 for <dev@dpdk.org>; Tue, 29 Sep 2015 08:24:47 +0200 (CEST)
Received: by oibi136 with SMTP id i136so103349548oib.3
 for <dev@dpdk.org>; Mon, 28 Sep 2015 23:24:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=r3JRNuQCS76VNV+QhMvdKf5gaz92OC6lJnvXeLX4qsI=;
 b=YuAiZ9PYHgHy8UzBTKJO8ZkEgVW7qjZFOSiWbi1at9RgDnaQHZI9QWvaacubowTrJ5
 0p5IiDIxnorI5nunxQmDyrKuKlmn4c2e7d7COQkkgMB0Xec3yA/11l5ks61EhjaybCUj
 3iP1wupID2OJj/BsMoA6epiA/ruInLX6dYPP1voD7bUY0mfOSOSe3+VOJ48LDDhtz6Hy
 /vPd71dQtUujudMVk+FjgKcPFAHlkp2qVJlabxH9B7Zl83ORIXNAS4IQAFe3P2PkHGxL
 cez/2n4RqvwcwaqO5/FywzTXThMfvgZDX6/gl2Ob/oROG3DVj+fKd0dsllLK5Bd9DHdE
 /Zww==
X-Gm-Message-State: ALoCoQmEsj5hx8qYwpZWzSY5YNgOIlkMayn9FzlxOlkox7Sm2BWa1hInvl61c4R4UbwbFcFabHQP
MIME-Version: 1.0
X-Received: by 10.202.207.197 with SMTP id f188mr11695941oig.90.1443507886910; 
 Mon, 28 Sep 2015 23:24:46 -0700 (PDT)
Received: by 10.76.131.166 with HTTP; Mon, 28 Sep 2015 23:24:46 -0700 (PDT)
In-Reply-To: <5606a0f0.9e18190a.7bb4d.44f4@mx.google.com>
References: <5606a0f0.9e18190a.7bb4d.44f4@mx.google.com>
Date: Tue, 29 Sep 2015 08:24:46 +0200
Message-ID: <CALwxeUv2_3twRgRzf7iKdyq0oU8nFdC-bvcSa0ysRWRsrjLB7Q@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Christoph Gysin <christoph.gysin@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 06:24:48 -0000

Hello Christoph,

On Sat, Sep 26, 2015 at 3:09 PM, Christoph Gysin <christoph.gysin@gmail.com>
wrote:

> 'virtual' is a keyword and can't be used if the code is to compile with
> C++ compilers.
>
> If rte_devargs.h was included in C++ code, compilation with clang++
> failed with an error. g++ did not fail, but only because of a bug
> that treats it as an anonymous struct with a decl-specifier which it
> ignores.
>
> This simply renames the member to 'virt'.
>

Ack with your signed-off.

-- 
David Marchand