From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by dpdk.org (Postfix) with ESMTP id AE9232C24 for ; Mon, 19 Feb 2018 13:31:01 +0100 (CET) Received: by mail-it0-f68.google.com with SMTP id l187so9132667ith.4 for ; Mon, 19 Feb 2018 04:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6R5no6rFH9hldhW1g6wMDZNNWw7ra39bgNATZ3Ns/Rc=; b=XqFHP0gDq2hxrEn/d6oU/hRSljUqeV/Nlfn41dIvTrVQE2hHsIsFGXar0fJ/2pVxn3 9vcr8moSYsgA8SLmv/ddDnebAplV9UUjjlu0rgycEhqoVjJNoAmCJUdZzvLUlM3RX2DO pFMoAftzmUv4IsQ6oyM6gLFP4hbgsOqvB27/iENlKelaUUfe0UF04AFO/IY2HDo+2Z0M /9Wk9yWst3EkJvsasyjBwlWirmI1nek5OOVo7qk315x6Dq+IsU0FIxl5JrB+Qt70TQ+4 5EW0EgGjaJlNct2jHPy31Ai1eKEFSiZkXBkyqn+YGAnId8tFUntJO1z9TD8DqAFG2h2b ZjfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6R5no6rFH9hldhW1g6wMDZNNWw7ra39bgNATZ3Ns/Rc=; b=qR8kOzgUoxmFsLafisN+M0TdrRKGO1OwG52FAahnXMYz6g5duQBJMvY+lSoighxBNn 5DpcUVxfo4C+8Oau8yfXjE3MoyrMMk2alMiygDSxu1K6tqCUmnULFP1lImqH9mp2JJpK G7+Vj2KhF/F70WCGEXN9mg/dqgou3Gzav8Dyk+h88VharbcVy8ZcdTZCvgLP9x8VvQlz t+QS/XcxSTqTxcob4ZyhWTmK6GyU6rTS6MM83/u7h6fW2l2RhS4Gr/c0K9kNluugdlYZ 6b4jRSncnNnxj7pZtY3J2MAm4Mz3IJph4MhzdwxHqtH42efO2DPTsHeCDTPMGox8l2XD FTSA== X-Gm-Message-State: APf1xPCDYnd2s5JM4nQsrcDwJOxZmxvr2+6XVqt13sVTTZNHZx4XmCjk SNJGMq602qgrDq2Hny17FJ6R/xHaXO6hLXBScGyWDg== X-Google-Smtp-Source: AH8x225HAONEyO2aW9Pwouh1DvdU8xTY1nqoVYftG+Yxjt0nV4vX1hS+zSyOXMlTF2cR+KN8+FShTP67Pe5PwJrpboM= X-Received: by 10.36.252.65 with SMTP id b62mr7683401ith.50.1519043460771; Mon, 19 Feb 2018 04:31:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.137.14 with HTTP; Mon, 19 Feb 2018 04:30:40 -0800 (PST) In-Reply-To: <20180219003955.18775-1-3chas3@gmail.com> References: <20180219003955.18775-1-3chas3@gmail.com> From: David Marchand Date: Mon, 19 Feb 2018 13:30:40 +0100 Message-ID: To: Chas Williams <3chas3@gmail.com> Cc: dev@dpdk.org, "Lu, Wenzhuo" , Chas Williams , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/e1000: add mac_addr_set set to em X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 12:31:01 -0000 On Mon, Feb 19, 2018 at 1:39 AM, Chas Williams <3chas3@gmail.com> wrote: > From: Chas Williams > > Based on the equivalent code in the igb driver. > > Signed-off-by: Chas Williams > --- > drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c > index 242375f..5bb9cc9 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -94,6 +94,8 @@ static int em_get_rx_buffer_size(struct e1000_hw *hw); > static int eth_em_rar_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr, > uint32_t index, uint32_t pool); > static void eth_em_rar_clear(struct rte_eth_dev *dev, uint32_t index); > +static void eth_em_default_mac_addr_set(struct rte_eth_dev *dev, > + struct ether_addr *addr); > > static int eth_em_set_mc_addr_list(struct rte_eth_dev *dev, > struct ether_addr *mc_addr_set, > @@ -190,6 +192,7 @@ static const struct eth_dev_ops eth_em_ops = { > .dev_led_off = eth_em_led_off, > .flow_ctrl_get = eth_em_flow_ctrl_get, > .flow_ctrl_set = eth_em_flow_ctrl_set, > + .mac_addr_set = eth_em_default_mac_addr_set, > .mac_addr_add = eth_em_rar_set, > .mac_addr_remove = eth_em_rar_clear, > .set_mc_addr_list = eth_em_set_mc_addr_list, > @@ -1809,6 +1812,15 @@ eth_em_rar_clear(struct rte_eth_dev *dev, uint32_t index) > e1000_rar_set(hw, addr, index); > } > > +static void > +eth_em_default_mac_addr_set(struct rte_eth_dev *dev, > + struct ether_addr *addr) > +{ > + eth_em_rar_clear(dev, 0); > + > + eth_em_rar_set(dev, (void *)addr, 0, 0); > +} > + Even if copied from igb, this cast is unneeded. I wrote a similar patch which was in the "upstream" queue, so looks good to me. Reviewed-by: David Marchand -- David Marchand