From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 177C7DE0
 for <dev@dpdk.org>; Thu,  9 Jan 2014 14:46:34 +0100 (CET)
Received: by mail-pa0-f48.google.com with SMTP id lf10so1019060pab.35
 for <dev@dpdk.org>; Thu, 09 Jan 2014 05:47:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=UqeRWHpEvq0FqDDBLSQVjEXD0lmJT8BB8rATtW2FT9I=;
 b=XARVtZVpU5zuirB+vUE9HVseM2V4FPGPG5X9Wqfg4RxY08+YjkmJFvbu3sZ6blYCWz
 xHUfm+64N7F8iTH/N/sJycow55cx5wBu5eE/gUzKq1WmN+hkFOpBXVAjxDp6vf69XbJG
 l5Wm2KeFmFkRlpKwULcqDl5UCKs/xIPAPbnXBAgTji/MK01Ix/lul0GmjJ/Rp2SDGbjk
 olgsBDp0uJlllRJmVbbtmc+iT3aH64BwWc/utxnwIifaql+Kyuk9x0DxeS1EBxcH1caI
 xttzeYQL1qI1cMbqWPAL6g1wZ+QGchgxViParAD6G4U7yNuAASGr9qMpFmx0UgrbLo1K
 1oMA==
X-Gm-Message-State: ALoCoQkCnQmlq44EgqtDSbw7P7TL5MjP3+1ghw/0mbn4szxsGDANgCG+C7k+tonswAb76ixs6+Y5
MIME-Version: 1.0
X-Received: by 10.66.226.46 with SMTP id rp14mr3675062pac.133.1389275266930;
 Thu, 09 Jan 2014 05:47:46 -0800 (PST)
Received: by 10.68.249.3 with HTTP; Thu, 9 Jan 2014 05:47:46 -0800 (PST)
In-Reply-To: <CA+xJJ1_HcnWxnAg6Z2j-Rcbz4U2TjwpX85ci_XhBTNjEH3MjdQ@mail.gmail.com>
References: <CA+xJJ1_HcnWxnAg6Z2j-Rcbz4U2TjwpX85ci_XhBTNjEH3MjdQ@mail.gmail.com>
Date: Thu, 9 Jan 2014 14:47:46 +0100
Message-ID: <CALwxeUv94wAd0K+W_iY8wXy6vMpnQJTrZkoAFO46oQ9_GBq0Mg@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Mats Liljegren <liljegren.mats2@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] No information about needed pcap version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jan 2014 13:46:35 -0000

Hello,

Indeed, this check on a define is wrong.

pcap.h does not seem to have information on library version (nor a #define
linked to pcap_sendpacket functionality).

We need to think of a better check but, for now, you can try to #define
PCAP_SEND to 1 in lib/librte_pmd_pcap/rte_eth_pcap.h.
pcap_sendpacket() is undefined for really old versions of libpcap (I think
< 1.0.0).
I suppose we might need something like configure (trying to link against
pcap lib and see if pcap_sendpacket symbol is defined).

Or we can revert 4fc6677d995bb46ddf155ee08a215f41e5ecbfe8 and declare
libpcap < X.X.X unsupported.


-- 
David Marchand


On Thu, Jan 9, 2014 at 12:59 PM, Mats Liljegren
<liljegren.mats2@gmail.com>wrote:

> In file lib/librte_pmd_pcap/rte_eth_pcap.h there is a test to see
> whether function pcap_sendpacket is a macro or not. If not, send is
> not supported using pcap.
>
> My pcap library do have the function, but not defined as a macro.
>
> I'm using libpcap-dev version 1.4.0, but I couldn't find any
> information in the manuals what version I need.
>
> Which version do I need to make this work?
>
> Regards
> Mats
>