From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com [209.85.218.51]) by dpdk.org (Postfix) with ESMTP id B88D32A5F for ; Thu, 29 Oct 2015 13:34:00 +0100 (CET) Received: by oiao187 with SMTP id o187so30230864oia.3 for ; Thu, 29 Oct 2015 05:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=dBQZDydSz9elcxc1OIy9Xckzhaoqiv0V/rmXdNzDdqg=; b=kwqvrHvyOZSBUvjO/2FscTYdIB2gssTkcM+TmjVwVyI5K4YB+vIz6d3iQWdc1CKAfF 7kzKTkWh/j2zw43JDm8gZMHm5L5lE2xHYYrFC68Xivk5gSmz24cR6V5rVgB6M8MzmNVw b1Qp2N6GMvGaMx/EZIQVeGWOPV1seEu6W9OHaZkHqE65W4cifaE2681aKUXwBM89Vjf3 +E5RQDiJdK4NBz19zIF+rSZvu7utZggUbKzeKICggeaPgbRc4XvONyrbzJFx7HBhLjke lB9zWMCrIuxNb+gjr3LfBgBM2LCA52fZBojdtbgJgPJITeJW8MQlPOXrtn7qrPC154uW ciXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=dBQZDydSz9elcxc1OIy9Xckzhaoqiv0V/rmXdNzDdqg=; b=f5DaNZH3UadXF2z2R9EjjOUn6YJkziGtl7ro3oSGDPJVrDsEQJvy9sgSs4TP7kKKbm KmcZKFIKucvvG4sxIUfJu/ZIXh1DPU/KwWdaps/V0fNiKK9iwbSqajKIimjqGmzexAld /j2j9xP8W+SNTDjC8NFOYPVoOjiy8lVvvycR0R7vPdjGHp2byVR9HdOnumpOh8SZ0CkR KsmNjnwNsE1Ma8efJwERs9jq92k0dzdoeRFFM+EyEhlI9d69Bp9RZj93wCuhNpugd7r6 JGd/vdQ0CivbJKk4n6DX2246X3Tlzh0lwlGGsQ/+kDzWTgkjH2Ebf92ljVsYQRrzDsku k6ew== X-Gm-Message-State: ALoCoQkqqV2b79IoPb8X/lcJaWM3QOM/C11vSV2U+fEkFZsVB5a5kGPT7Czhfbufx9TYfqcEaYmv MIME-Version: 1.0 X-Received: by 10.60.140.228 with SMTP id rj4mr857261oeb.15.1446122039921; Thu, 29 Oct 2015 05:33:59 -0700 (PDT) Received: by 10.76.131.166 with HTTP; Thu, 29 Oct 2015 05:33:59 -0700 (PDT) In-Reply-To: <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> Date: Thu, 29 Oct 2015 13:33:59 +0100 Message-ID: From: David Marchand To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 12:34:01 -0000 On Fri, Oct 23, 2015 at 5:53 PM, Thomas Monjalon wrote: > +for p in "$@" ; do > + printf -- "\n### $p\n\n" > + report=$($DPDK_CHECKPATCH_PATH $options "$p" 2>/dev/null) > + [ $? -ne 0 ] || continue > + printf '%s\n' "$report" | head -n -6 > + status=$(($status + 1)) > +done > +exit $status > I prefer when checking scripts only complain when something is wrong :-) So I would only display the file name if checkpatch complains. -- David Marchand