From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f171.google.com (mail-ob0-f171.google.com
 [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id C9284B40E
 for <dev@dpdk.org>; Fri, 13 Feb 2015 12:08:20 +0100 (CET)
Received: by mail-ob0-f171.google.com with SMTP id gq1so18684236obb.2
 for <dev@dpdk.org>; Fri, 13 Feb 2015 03:08:20 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=OJGb1VQn8W06jY25RvO3amGLmiVeGsYotH4qr10RYBs=;
 b=GfQaGuhiUl2dUEpu7sGekPRpkZ1NibkrXqpLOARHbKPL8rcoJVGWVew7ZLpKlUbwk1
 9F8GVgzPeGnHm0v5GMyOWUNyTk07Sg6ZVX4aYaAkSJcuwUShZgeYcZovw1K7mlS4Wlvy
 HXXZOoOi4OKVXqfQN2zmJ18j9azAgJ3JVji+E5cdFKLp+o5MMFq9PlKB6AH8DpA3DrXo
 lDd4iQQE7DUoy2fAjOa+yESOkRB5o3zRpZXiGo42g4UsR2eeOYH4jfi+y7zJC3rUvR8E
 a3R9GZlMuTvjj+9u2TOaDdM/ANjb7PJyMvaFPbwq48LrqoUlGrhSlxffN9yExAcV+n0P
 uD/w==
X-Gm-Message-State: ALoCoQlelQmaITiSq8shDfh23ZIA6hpIVjt01SjHdRBoD9Dy6CJhBZFGaOzXKZKLNDKRD9DObGSy
MIME-Version: 1.0
X-Received: by 10.182.213.38 with SMTP id np6mr5964972obc.34.1423825700261;
 Fri, 13 Feb 2015 03:08:20 -0800 (PST)
Received: by 10.76.95.198 with HTTP; Fri, 13 Feb 2015 03:08:20 -0800 (PST)
In-Reply-To: <1423815597-17819-7-git-send-email-jing.d.chen@intel.com>
References: <1423618298-2933-2-git-send-email-jing.d.chen@intel.com>
 <1423815597-17819-1-git-send-email-jing.d.chen@intel.com>
 <1423815597-17819-7-git-send-email-jing.d.chen@intel.com>
Date: Fri, 13 Feb 2015 12:08:20 +0100
Message-ID: <CALwxeUvHAQFswoWy6wNQLjbrSuXO7=uMn=GZn2ByK2g9iRdfeg@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 06/17] fm10k: add rx_queue_setup/release
	function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Feb 2015 11:08:21 -0000

Hello,

On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) <jing.d.chen@intel.com>
wrote:

[snip]

+static int
> +fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
> +       uint16_t nb_desc, unsigned int socket_id,
> +       const struct rte_eth_rxconf *conf, struct rte_mempool *mp)
> +{
> +       struct fm10k_hw *hw =
> FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +       struct fm10k_rx_queue *q;
> +       const struct rte_memzone *mz;
> +
> +       PMD_INIT_FUNC_TRACE();
> +
> +       /* make sure the mempool element size can account for alignment.
> Use
> +        * RTE_LOG directly to make sure this error is seen. */
>

Comment is not valid anymore since you call PMD_INIT_LOG.



> +       if (!mempool_element_size_valid(mp)) {
> +               PMD_INIT_LOG(ERR, "Error : Mempool element size is too
> small");
> +               return (-EINVAL);
> +       }
> +
>

-- 
David Marchand