From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f179.google.com (mail-ob0-f179.google.com
 [209.85.214.179]) by dpdk.org (Postfix) with ESMTP id 485E5591A
 for <dev@dpdk.org>; Tue,  2 Sep 2014 21:15:05 +0200 (CEST)
Received: by mail-ob0-f179.google.com with SMTP id uz6so5266770obc.38
 for <dev@dpdk.org>; Tue, 02 Sep 2014 12:19:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=DzJlMjOfMcQRkSmkWYDYbNo/g9tibANjwgUKLnPAbIc=;
 b=MOxQUQ/nR8wQ3o1zihrtkkt9SV8k3S533fW1DZZWVKc7sC7kzvS+UnjxbdMK+Nd7n7
 1bHCUflMfHXgkfe6NTnzeCWVKJqk/x+q42/vmSaMN7YEuNHbaT98OgTnyOXMMstjHMrc
 GRq4/eQZ1FXpEVbAs9U5YdgNdGIGV2No9eMs8eTvNw0pS8gNLwC70T9eI7rgSiosw2XA
 Rnv38YYwLLnzlkBkLBzbh7sSA7zwwtOSgYx9CU6YJAqWvEveujrnFyawQ1mNaIXZ/HJL
 BM4PdcSpDJ4ZVkehp5KZMNvUWVq8S73wX4JLztrPDpUDbvQj1bJD5A1LPLl1AkzjlPSO
 OZZg==
X-Gm-Message-State: ALoCoQmzHc6n5AVoZEUA2qRSHyrWfd8Ac+bHm/KmsQtcqLS4yf8fjoBF2x0f4TvS7fpm1cd8LhjX
MIME-Version: 1.0
X-Received: by 10.182.231.170 with SMTP id th10mr33379822obc.8.1409685577419; 
 Tue, 02 Sep 2014 12:19:37 -0700 (PDT)
Received: by 10.202.73.74 with HTTP; Tue, 2 Sep 2014 12:19:37 -0700 (PDT)
In-Reply-To: <CADNuJVqhOy6AfYO5OuUn=kmQsBVkwrRunXKXKkQ88bexPtWgsg@mail.gmail.com>
References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com>
 <1409567080-27083-15-git-send-email-david.marchand@6wind.com>
 <CADNuJVqhOy6AfYO5OuUn=kmQsBVkwrRunXKXKkQ88bexPtWgsg@mail.gmail.com>
Date: Tue, 2 Sep 2014 21:19:37 +0200
Message-ID: <CALwxeUvLyFthbf8aaEpGkbCvhsWy+M7dfQr4+VusurBAOddBvA@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Jay Rolette <rolette@infiniteio.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 14/17] e1000: clean log messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Sep 2014 19:15:05 -0000

On Tue, Sep 2, 2014 at 9:05 PM, Jay Rolette <rolette@infiniteio.com> wrote:

> Couple of minor nits noted. The bigger feedback would be that if you could
> keep the "whitespace / line-wrapping / formatting" only changes in separate
> patches, these reviews would be easier to get through.
>

Hum, indeed, I should have done this.
Will keep in mind.


        /* Free memory prior to re-allocation if needed */
>>         if (dev->data->tx_queues[queue_idx] != NULL) {
>> @@ -1271,7 +1271,7 @@ eth_igb_tx_queue_setup(struct rte_eth_dev *dev,
>>                 igb_tx_queue_release(txq);
>>                 return (-ENOMEM);
>>         }
>> -       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p
>> dma_addr=0x%"PRIx64"\n",
>> +       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64"",
>>
> The empty string after PRIx64 is extraneous
>
>
>>                      txq->sw_ring, txq->tx_ring, txq->tx_ring_phys_addr);
>>
>>         igb_reset_tx_queue(txq, dev);
>> @@ -1409,7 +1409,7 @@ eth_igb_rx_queue_setup(struct rte_eth_dev *dev,
>>                 igb_rx_queue_release(rxq);
>>                 return (-ENOMEM);
>>         }
>> -       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p
>> dma_addr=0x%"PRIx64"\n",
>> +       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64"",
>>
> The empty string after PRIx64 is extraneous
>
>

Ok, I will update.

Thanks.


-- 
David Marchand