From: David Marchand <david.marchand@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: add missing long-options for short option arguments
Date: Thu, 3 Mar 2016 15:55:43 +0100 [thread overview]
Message-ID: <CALwxeUvTSO125pyD5kZmUMPsSAsgjQRSNeQAon1MsSmt1AgewA@mail.gmail.com> (raw)
In-Reply-To: <AA049994-42DF-45FB-AA70-B013E427A0FF@intel.com>
On Thu, Feb 25, 2016 at 11:12 PM, Wiles, Keith <keith.wiles@intel.com> wrote:
>>On Thu, Feb 25, 2016 at 01:09:16PM -0600, Keith Wiles wrote:
>>> A number of short options for EAL are missing long options
>>> and this patch adds those missing options.
>>>
>>> The missing long options are for:
>>> -c add --coremask
>>> -d add --driver
>>> -l add --corelist
>>> -m add --memsize
>>> -n add --mem-channels
>>> -r add --mem-ranks
>>> -v add --version
>>> Add an alias for --lcores using --lcore-map
>>>
>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>>
>>Why do we need long options for all the short options?
>
> I think we need the long options to match the short options just because it makes sense to me to have long options for all short options. Take the case of -v, just about everyone else has a —version long-option, but we do not.
>
> The real reason is to allow for DPDK configuration via a configuration file and I wanted to use the same strings for the config file variables as the command line options. I figured I would add the long options now as they do not effect the configuration file patch.
No strong opinion on this.
Just, why "memsize" with no - but "mem-channels" ?
And why cut down to mem rather than memory ?
--
David Marchand
next prev parent reply other threads:[~2016-03-03 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 19:09 Keith Wiles
2016-02-25 21:32 ` Bruce Richardson
2016-02-25 22:12 ` Wiles, Keith
2016-03-03 14:52 ` Wiles, Keith
2016-03-03 14:55 ` David Marchand [this message]
2016-03-03 15:02 ` Wiles, Keith
2016-03-18 10:50 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUvTSO125pyD5kZmUMPsSAsgjQRSNeQAon1MsSmt1AgewA@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).