From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f176.google.com (mail-ob0-f176.google.com [209.85.214.176]) by dpdk.org (Postfix) with ESMTP id EDADC2B94 for ; Thu, 3 Mar 2016 15:56:03 +0100 (CET) Received: by mail-ob0-f176.google.com with SMTP id xx9so21962115obc.2 for ; Thu, 03 Mar 2016 06:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KMaAfnozICxuuJD2TOEajrpMDKFph+YbnyBGYn3ImZQ=; b=RBorbFL2wYC0K5i6iFR4tXZhFUOV+VXBifZ5LWokmJkfN9u9eF4ohBoPgE/mXX/oRw gZ1vOWECbRpIqUdpfnmm9qgMUrcy7ugvv3lowi8CNbusd4Sm+TuitlzpVM6OjX6A6epi ZxXW1oZMx6cYPSJi6bhZ+YnWdPf9TOMuuwNFFYqF8JWLlyr9P232UMgjrWPPOeezQKKF MJ2jadgkLBdq9vUdT+KR1Qtl1BmMY47JGSbrHXghZt42uWxHHWMwYk+3Wo6bBbArGU0G +zJse0XZnoQA1JPkVGGJmi3rrGNOObRVfL0seB30BN+qCbWomWRYghKUbisyqIHngMg2 Qy9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KMaAfnozICxuuJD2TOEajrpMDKFph+YbnyBGYn3ImZQ=; b=HnfCjpk+GOQiSEr8uPJc54tIdvj3Lm95r0MwQQyHsFtfE3lsNR32rhEfcS9lpqjQMD ws0VLk7iIf76C8+5B7gD+O/kpCBUw9L78D+MqO8Zduv81TkDnta8dwo23i0amrVaHub2 FZh1mxKsitcj40h6iu6A0mcp/p3aC0PTLw8h5YzKHpjgt7RX6OGoX1ksvLy4SgctpSMK jnSTvOmR4idNJaJqRvMHsUzNG+odjlrRyiA+b5NhAL8LVqiGZwZoHLJYpolfdEyBTmg0 vaJ2KTnamm/SBGvibWFYKPBD4CR8D8pstMe05JU5k6vK3YXm/NCqORY+MXebQklDjBLm 8lfQ== X-Gm-Message-State: AD7BkJJk7KENqLIhgPQiZYUJrJ26rq1VyvUYt2CqbxcpH1GwNfndgRIKzlyEzU4xG81+rW1/Hdgp5UFXZcI9sh8E X-Received: by 10.182.24.131 with SMTP id u3mr2151626obf.58.1457016963411; Thu, 03 Mar 2016 06:56:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Thu, 3 Mar 2016 06:55:43 -0800 (PST) In-Reply-To: References: <1456427356-67147-1-git-send-email-keith.wiles@intel.com> <20160225213203.GB14936@bricha3-MOBL3> From: David Marchand Date: Thu, 3 Mar 2016 15:55:43 +0100 Message-ID: To: "Wiles, Keith" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: add missing long-options for short option arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 14:56:04 -0000 On Thu, Feb 25, 2016 at 11:12 PM, Wiles, Keith wrot= e: >>On Thu, Feb 25, 2016 at 01:09:16PM -0600, Keith Wiles wrote: >>> A number of short options for EAL are missing long options >>> and this patch adds those missing options. >>> >>> The missing long options are for: >>> -c add --coremask >>> -d add --driver >>> -l add --corelist >>> -m add --memsize >>> -n add --mem-channels >>> -r add --mem-ranks >>> -v add --version >>> Add an alias for --lcores using --lcore-map >>> >>> Signed-off-by: Keith Wiles >> >>Why do we need long options for all the short options? > > I think we need the long options to match the short options just because = it makes sense to me to have long options for all short options. Take the c= ase of -v, just about everyone else has a =E2=80=94version long-option, but= we do not. > > The real reason is to allow for DPDK configuration via a configuration fi= le and I wanted to use the same strings for the config file variables as th= e command line options. I figured I would add the long options now as they = do not effect the configuration file patch. No strong opinion on this. Just, why "memsize" with no - but "mem-channels" ? And why cut down to mem rather than memory ? --=20 David Marchand