From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f196.google.com (mail-yb0-f196.google.com [209.85.213.196]) by dpdk.org (Postfix) with ESMTP id BAC2C4C8B for ; Fri, 29 Jun 2018 09:05:07 +0200 (CEST) Received: by mail-yb0-f196.google.com with SMTP id e84-v6so2989106ybb.0 for ; Fri, 29 Jun 2018 00:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PPcKBQV2AD5Jrisp0CoKdWben/JVJZLlxCSvfgqjMbM=; b=kLWWhYwvRb/DoG0SUacjukputbvi7CuV7a2G3ZO26z4ZMy/YrkOeSMB7cIpJlzOJbh LRHKtoyHbBFaf6ZXUBuxqXXF9BOpRV4ozgmUCO3fXa0cEV9SJKP4URCrYOcJsDlfRINS dBWKf4IEcFdxzXi/8DLJ2AlJRB01Sw2HRH8wxC3fVzEVJZAT8vUOOETvS8umhnos7DyX Pd2yDt/DPL53mp4zjgFoAOfUtbW4Jt6JEix2Iz3g5uMhuDUEQmIJg4LM3z//kajY65sd 12ge9gPtf2jx3+h2UL99x88LzW54qdHIzEyY1cZ8nG9tlHoTe2AZYSWPxZq5hvxBQ6tt ihxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PPcKBQV2AD5Jrisp0CoKdWben/JVJZLlxCSvfgqjMbM=; b=rTDpeWX1X55UXdRNBMNLEAOsziaJeinLj9sELAIwLonwQhkaNNqF5cvtgwMqm20/2x MYUcttjf/HRkY5ghAPNvV/14I36OgJXOxlCUz5tlm5M5//XfxjarMvx1hSrak302+YuW t2c+qBt45xy3d4tAUWe1/p/ZQxqurVFqlZOODl4EC2m3KKOKZl039sf/CnUEqG2+2GEW tFAh21Xd88SVDHnj6CbThskLMNLjMPqoXSZffRfvZi954iyL1w6EBchqgTObgwiFW6Tv SfH2LNgGw9zni+vvoTKJi5+DJ5MldmhX7xfRB6AnMncUj6oCyeKkPngkzRXm45hSSbDp XH6A== X-Gm-Message-State: APt69E2BUFmAEmyRKsHRCaiv2M7YTDmiHQwL9AIA2MndWK8zDFX0k96A dJ3axxHIJbcs7g6Ekj0a8zROvf+DErKnwyEPRpcsKA== X-Google-Smtp-Source: ADUXVKJ7Fnp/7ghC/ZmFe+ZgpkEJtKJdjhkW/G+38aUOaelVjuOzMsYKt/AqnoGcDAXb/mJm8xr3V2h9z4J3rHnRack= X-Received: by 2002:a5b:287:: with SMTP id x7-v6mr6820415ybl.476.1530255906963; Fri, 29 Jun 2018 00:05:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:a282:0:0:0:0:0 with HTTP; Fri, 29 Jun 2018 00:04:46 -0700 (PDT) In-Reply-To: <20180516144220.21235-1-ferruh.yigit@intel.com> References: <20180516101851.2443-1-ferruh.yigit@intel.com> <20180516144220.21235-1-ferruh.yigit@intel.com> From: David Marchand Date: Fri, 29 Jun 2018 09:04:46 +0200 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Christian Ehrhardt , Luca Boccassi , Maxime Coquelin , Neil Horman , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] igb_uio: fail and log if kernel lock down is enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 07:05:08 -0000 Hello Ferruh, On Wed, May 16, 2018 at 4:42 PM, Ferruh Yigit wrote: > @@ -136,3 +132,22 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev) > #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0) > #define HAVE_PCI_MSI_MASK_IRQ 1 > #endif > + > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 8, 0) > +#define HAVE_ALLOC_IRQ_VECTORS 1 > +#endif > + > +static inline bool igbuio_kernel_is_locked_down(void) > +{ > +#ifdef CONFIG_LOCK_DOWN_KERNEL > +#ifdef CONFIG_LOCK_DOWN_IN_EFI_SECURE_BOOT > + return kernel_is_locked_down(NULL); > +#elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN > + return kernel_is_locked_down(); > +#else > + return false; > +#endif > +#else > + return false; > +#endif > +} Missing some defined() for the check on CONFIG_EFI_SECURE_BOOT_LOCK_DOWN. It causes a build error with ubuntu-16.04 hwe for aarch64. I can send a patch. -- David Marchand