From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.marchand@6wind.com> Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 97A285398 for <dev@dpdk.org>; Fri, 8 Jul 2016 10:49:45 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id n127so8488111wme.1 for <dev@dpdk.org>; Fri, 08 Jul 2016 01:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oat48+iRv9ktEQyX2BH4hCfpbsdlas9vOXM7i2czyAg=; b=1O9PAVcurlHgOiPJBJ+lkzwq2yyjA1dcZRo0mG8fLqHDze77VYoBfhzZrc7mcOnQj2 CsHc+hUhk6ZeXsodtQpwk1ycx9NxZrHOgx2fUEhB5N4stdmkFGfrjvBvdoQ2uXN+8xAu R1zVIBVYLeXNwT6a2mDFHNBSSXU1F2nDb6TDC7xHbxBtBmONn2JQbB5agRCLKv1+ftps mTgY3gSwsu3vlEF05IR3Id4YjPtzJ0WvJu5EXn8cQ11jm6sjh8GVm6Qwc9tMN/+y0W5m thl4p9h7fuZNIrQ2XipkQmEFtSOFGVyt14GMBhYHApVQCTB3D1fDarHTC+BHtRF6pZCl FFHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oat48+iRv9ktEQyX2BH4hCfpbsdlas9vOXM7i2czyAg=; b=nAY+Uxr2B3UGfn6V1U6fGOOKPpoaEY0sGEEArB+adglZUsdGxyWdg5OqAG8JzD3n6C HLXworBeqWL2BBG7IjbaOTsIL6iG6AvwKJ0EBT1eAgSk6Z8ebi/5jfg2t09SXbPuKPh/ 7Tehpt9+mY1zIADJheY32AfMGoLMrfWzfhsL9c0XkR70BXAoddyAOM9nOYxZ4txZqdbk jevaQ8bnITLGhm8hg9SCYus6k1UbgKZnHhMCkzlqXKe5XmHXkBLfizwbw+O4UiYd48Yt cCCNTNEnObAaj9TXZx4bS/P7SmFVdRVh1mOGjPVzy5xFmxqiboCgEKmP56Lta32+OJSl ldSg== X-Gm-Message-State: ALyK8tIV0tCLXgZj6vhZT0cGgD+L5+iP8LBWoMitApHd+RNYIcXvSlUJCNKskOCkHTWFrhV8GjJ/iXr7YyIT5YfH X-Received: by 10.194.73.38 with SMTP id i6mr4622908wjv.173.1467967785363; Fri, 08 Jul 2016 01:49:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.46.69 with HTTP; Fri, 8 Jul 2016 01:49:25 -0700 (PDT) In-Reply-To: <4984337.X4DjHj7U46@xps13> References: <1467905790-10597-1-git-send-email-thomas.monjalon@6wind.com> <1467905790-10597-10-git-send-email-thomas.monjalon@6wind.com> <20160707161141.GH26064@hmsreliant.think-freely.org> <4984337.X4DjHj7U46@xps13> From: David Marchand <david.marchand@6wind.com> Date: Fri, 8 Jul 2016 10:49:25 +0200 Message-ID: <CALwxeUv_davrQO+wkTr8Ciqyt3LjgYooRaxN5aRzFLmE8vY6bg@mail.gmail.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>, Jan Viktorin <viktorin@rehivetech.com> Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 09/11] eal: move PCI table macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 08 Jul 2016 08:49:45 -0000 Hello Thomas, Neil, (will be back in a couple of days, thanks Thomas for pointing this thread) On Thu, Jul 7, 2016 at 6:25 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > 2016-07-07 12:11, Neil Horman: >> On Thu, Jul 07, 2016 at 05:36:28PM +0200, Thomas Monjalon wrote: >> > Remove include of rte_pci.h in the generic header rte_dev.h >> > and move the macro DRIVER_REGISTER_PCI_TABLE in rte_pci.h. > [...] >> >> This seems strange to me, in that its odd for the driver information export >> macros to be spread out in multiple locations. Specifically it enjoins the use >> of the DRV_EXP_TAG macro, which helps centralize tag naming. Perhaps the happy >> medium is to place all the export macros (includnig PMD_REGISTER_DRIVER) into >> its own pmd_register.h header? > > I don't know. > David, your opinion? - The suggestion I did offline to Thomas was to move pci stuff in pci headers. We are trying to move from the "all pci" code in eal to accomodate for other "buses" / architectures. Having a pci macro in a generic header like rte_dev.h is wrong to me. Moving this to a new header like pmd_register.h sounds like a new generic header with pci specific stuff in it. So, I am not sure I follow you Neil. Can you elaborate ? - Why do you want to centralise the tag naming ? To avoid collisions ? Well, adding those tags should not happen that often and I think we can maintain this with careful reviews. -- David Marchand