From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 547C18DA8 for ; Wed, 28 Oct 2015 15:54:48 +0100 (CET) Received: by oies66 with SMTP id s66so5784893oie.1 for ; Wed, 28 Oct 2015 07:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=AxdwtHqxQKFYsBHFzfbHbWQuqxY1rwrhAf4IAm9QdjI=; b=oCipIm9cgHx8+8RMGVftcpG7kLpxwumFAhBMNoP9ohO2XyecGklqksh+THzUnCKDuK uFAwoiTrFEmB6Ca30U70jgQkEd61qlb+PCOwI5P9nAN4cFQ4r+jrmjchNL/nrwrIvUTH tJtXA9voiq5ZXyeuLDcW67MBcK9tx5o9DCrwyk6NMJIcxKwxjXIMrjWdRcrzIc2thcAq 85zraHtXPgW2hQXWDuSZwjTAOpHmPF1+hcomb1z4NiZUxNdOxFqrxrk+riR6KTuTspM5 3xIFGpt9mqDOmCpEI+VuMVhqGPfAXTcMWmUjFgdRyz0YRqhq0p/xw/S+mwWGkRgUu3Ir m7MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=AxdwtHqxQKFYsBHFzfbHbWQuqxY1rwrhAf4IAm9QdjI=; b=QbPem3olreEMaW7c+P3X+X7zPYEqrFlT1uplEgGkhzsCFhfiPMUu/BPDsPvv2W2ulk 8YGBSD+TbJtcPw7KI6jpl/RCRx0Ye7tpCjEFgHwLFpAMm/mOdx74A1IJYaJVwtmbsKlb kTvOVY/pY7fBgyxki7XehUpSCv+quHDbCTCPsHb9BTnplhzzJWKKVu8bK7SrN4PWrsVT DQptKBpU7LiqX32hWoCT6uvkuLsdUpo0zX2yIBLH86SAx6YGfIYUJirWqI4J1JMUVTcY nbn4j7tYDRpQ7jjcXFHPhFw9/zFy57MhW6XCeEG1726GohhCtpirdmtYNg2mgCN8VIki QvxQ== X-Gm-Message-State: ALoCoQkXI/UTGrawDsyaL4PQp2JuvOEubGhMjGiTuP1fWMJaqgwbMOuNNRdQvv5xN4Tk9cDG46vm MIME-Version: 1.0 X-Received: by 10.202.71.9 with SMTP id u9mr26092922oia.118.1446044087675; Wed, 28 Oct 2015 07:54:47 -0700 (PDT) Received: by 10.76.131.166 with HTTP; Wed, 28 Oct 2015 07:54:47 -0700 (PDT) In-Reply-To: <1445973229-22058-1-git-send-email-viktorin@rehivetech.com> References: <1445877458-31052-1-git-send-email-viktorin@rehivetech.com> <1445973229-22058-1-git-send-email-viktorin@rehivetech.com> Date: Wed, 28 Oct 2015 15:54:47 +0100 Message-ID: From: David Marchand To: Jan Viktorin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 00/17] Support ARMv7 architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 14:54:48 -0000 Hello Jan, On Tue, Oct 27, 2015 at 8:13 PM, Jan Viktorin wrote: > Hello DPDK community, > > this is the third attempt to post support for ARMv7 into the DPDK. > There are changes related to the LPM and ACL libraries only: > > * included rte_vect.h, however, it is more a placeholder > * rte_lpm.h was simplified due to the previous point > * ACL now compiles as we detect whether the compiler > supports SSE 4.1 > This patchset looks good to me (with the minor comments I sent). And armv8 support should fit quite well in this. A last few things : - checkpatch is not happy with some patches, can you have a look at this ? - can you update the 2.2 release notes as part of this patchset to announce armv7 support ? - I am not really sure the acl et lpm fixes really belong to this patchset as a more larger cleanup is necessary to have all libraries compile fine on non-x86 - since you introduce a new architecture, do you intend to run daily build checks and send reports to the test-report mailing list ? Thanks. -- David Marchand