From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id 16C348E86 for ; Tue, 3 Nov 2015 12:19:51 +0100 (CET) Received: by obbwb3 with SMTP id wb3so9701908obb.0 for ; Tue, 03 Nov 2015 03:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ckXMuSdqJSZW3V2RT9kAZaywVv6gnz3RMD5YVq589mc=; b=vxBoLKvbcqTi5l0kPqDT/0brg02jxhKMs4eet4uyxaQItG5Xyr96fMLjQ6MfSvWnZW P434XPOuNYr4Q9IPUEk8+EI29htnFXs1qXIzzzbPfNT33Xu6uirvm2jfM8xeasSTys6v E2nqZ2owZSb3364Ex/AvZohqbLwKYLd7Fc61QCVLnqpAuwewa71CkdxlPNsBielL52/m 2D6LsJYHOPkxSSX3vk0qzeQ3eQtAB3I+p1aPM1K+RCni6WiwkAE/bbseM8pcddzxKHXK 429eWwlZDszsSJYlowfs6ajxrNyZJFXMzr58qVRZV/Dacre2zWtRKhgdVmIGdQuMmWW7 rzSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ckXMuSdqJSZW3V2RT9kAZaywVv6gnz3RMD5YVq589mc=; b=m4CMSn07tESPnWaXLjaEwQjeed91t3wAkXdAUeiilEqxGstn4YrzkYdiYeh4EvzND0 KZHoSuRLv7gWjHT7RN7gMGsPWN3aKrof8W3MsBGJPV1pfW11uP/gi0oK+Yuvo7xVmcM4 BzqKo/mRZjqKd4WACG4IjndZLa28F6SvReS8Y2y3SPkxbvp6y28dSc6MC26mZqXdNsCW ABetv5NYuWGxhIRMF21HH3jnch2+4K8Fo68ERL3PPU18ViLfRLokTFN20oF8hAZNc+R9 js0fX/WMRKQomPU1JqRW/+DjOmOM7cJTjd/HrCwQrgqIPFs6u6iZ81qV5gr326ZfxqCH kLQg== X-Gm-Message-State: ALoCoQmgkcTt+VGZwLgO2V/ufGbJVpTF7R4MQRcHRXZAoGFbKC421q5oI0OShCvaYGP4B/AYqAZM MIME-Version: 1.0 X-Received: by 10.60.39.6 with SMTP id l6mr18500681oek.62.1446549590488; Tue, 03 Nov 2015 03:19:50 -0800 (PST) Received: by 10.76.131.166 with HTTP; Tue, 3 Nov 2015 03:19:50 -0800 (PST) In-Reply-To: <1835472.4si0y6iqvT@xps13> References: <1446108903-14412-1-git-send-email-david.marchand@6wind.com> <1446108903-14412-4-git-send-email-david.marchand@6wind.com> <1835472.4si0y6iqvT@xps13> Date: Tue, 3 Nov 2015 12:19:50 +0100 Message-ID: From: David Marchand To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 3/3] ethdev: prevent segfaults in rte_eth_dev_is_detachable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 11:19:51 -0000 On Tue, Nov 3, 2015 at 12:10 PM, Thomas Monjalon wrote: > 2015-10-29 09:55, David Marchand: > > From: Maxime Leroy > > > > Some drivers like virtual ones don't specify any driver pointer in the > > structure rte_eth_dev. > > > > To prevent segfault, we should check if this pointer is NULL before > > dereferencing it. > > > > Signed-off-by: Maxime Leroy > > Signed-off-by: David Marchand > > It is not clear what the problem is. > And the driver fields should probably be removed or changed as it too > tigthly > related to the PCI driver. > It does look odd to me as well, quickly went through head, and did not see a case where this could happen. Maxime is not available at the moment, so I think I will just drop this patch. How about this patchset rebased on head with just the first two patches ? -- David Marchand