From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) by dpdk.org (Postfix) with ESMTP id 2EE2B678C for ; Sat, 27 Sep 2014 20:38:50 +0200 (CEST) Received: by mail-oi0-f46.google.com with SMTP id h136so587710oig.5 for ; Sat, 27 Sep 2014 11:45:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=x/1cvaKOxAbvm6gV77V3eRR0FUe/SYfzw/wMY6Jyit8=; b=kKDir0gll3zpgQptl1CWGLHLTN7fE9HXAp8VY+ElOysFJSU0vWmQVM0tROXN04Zr4C 5yZBn+Zo2A4qBk0sPNCEhyFNbP55d6g6/nmvtEY5R+puz5/kGmV3ToWxaOTHV6n8DDzm eJdv5CyML+BE/SNKAaZL0FkpUF86CWXwUTdcf7zcDUoHVrQTrY2COW/6l6DWsLY2qS9L VyRJvC52JgWtMrHbBrmwlwUeWb/PPNmmpiJhTP+gy93URbFk2UK7AArHEBiwfsD9zSqy LiKrjC+WISj4lR0kjD/wqx5Wy5rPVJu5E+dBrByeA1ZI52ZES5zqeYOQ5tBn26XcdYQB tY6Q== X-Gm-Message-State: ALoCoQnlffLRXdkRAzn6HGhOgDswQpfIwxYwBl/3hxpJZdnyQB28bQl0Uc/kf8Vlck9n1j6WK6od MIME-Version: 1.0 X-Received: by 10.60.174.197 with SMTP id bu5mr29550066oec.3.1411843517122; Sat, 27 Sep 2014 11:45:17 -0700 (PDT) Received: by 10.202.57.139 with HTTP; Sat, 27 Sep 2014 11:45:17 -0700 (PDT) In-Reply-To: <1411741159-6671-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1411741159-6671-1-git-send-email-pablo.de.lara.guarch@intel.com> Date: Sat, 27 Sep 2014 20:45:17 +0200 Message-ID: From: David Marchand To: Pablo de Lara Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2014 18:38:50 -0000 Hello Pablo, - All I can see in this patchset is stuff that should remain in the PMD (since this is really specific to them). - Anyway, if you want to let application get this information, why the new API ? >>From my point of view, this should go in rte_eth_dev_info_get(). -- David Marchand On Fri, Sep 26, 2014 at 4:19 PM, Pablo de Lara < pablo.de.lara.guarch@intel.com> wrote: > These patches add two new API functions to get an optimal values > for the RX/TX configuration structures (rte_eth_rxconf and rte_eth_txconf), > so users can get these configurations and modify or use them directly, > to set up RX/TX queues. Besides, most of the apps that were modifying > little > or none of the default values of the structures, have been modified to use > these functions to simplify the code and avoid duplication. > > Pablo de Lara (2): > pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults > functions > app: Used rte_eth_rxconf_defaults and rte_eth_txconf_defaults in apps > > examples/dpdk_qat/main.c | 44 ++----------- > examples/exception_path/main.c | 30 +-------- > examples/ip_fragmentation/main.c | 42 ++----------- > examples/ip_reassembly/main.c | 44 ++----------- > examples/ipv4_multicast/main.c | 44 ++----------- > examples/kni/main.c | 34 +--------- > examples/l2fwd-ivshmem/host/host.c | 43 +----------- > examples/l2fwd/main.c | 48 +------------- > examples/l3fwd-acl/main.c | 46 ++------------ > examples/l3fwd-power/main.c | 46 ++----------- > examples/l3fwd-vf/main.c | 31 ++------- > examples/l3fwd/main.c | 54 +++------------- > examples/link_status_interrupt/main.c | 43 +----------- > examples/load_balancer/init.c | 24 +------ > .../client_server_mp/mp_server/init.c | 41 +----------- > examples/multi_process/l2fwd_fork/main.c | 44 +------------ > examples/multi_process/symmetric_mp/main.c | 36 +--------- > examples/netmap_compat/bridge/bridge.c | 25 ------- > examples/netmap_compat/lib/compat_netmap.c | 6 +- > examples/netmap_compat/lib/compat_netmap.h | 2 - > examples/qos_meter/main.c | 36 ++++------- > examples/quota_watermark/qw/init.c | 26 ++------ > examples/vhost_xen/main.c | 31 ++------- > examples/vmdq/main.c | 60 > ++--------------- > examples/vmdq_dcb/main.c | 36 +--------- > lib/librte_ether/rte_ethdev.c | 68 > ++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 29 ++++++++ > lib/librte_pmd_e1000/igb_ethdev.c | 56 > ++++++++++++++++- > lib/librte_pmd_i40e/i40e_ethdev.c | 56 ++++++++++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 59 > +++++++++++++++++ > 30 files changed, 385 insertions(+), 799 deletions(-) > > -- > 1.7.7.6 > >